-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VIDCS-3252: Resolve GitHub Mend warnings for VERA #12
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also Tested the PR LGTM!! 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 💪 🚀
@@ -13,7 +16,7 @@ jobs: | |||
set -e | |||
|
|||
pr_name="${{ github.event.pull_request.title }}" | |||
echo "PR Title: '$pr_name'" | |||
echo "PR Title: '${pr_name}'" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this is just for tech debt? 🤷♂️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What is this PR doing?
This PR resolves the 2 issues mentioned in the
Issues
tab:#11
#10
How should this be manually tested?
We need to make sure that with these changes the
check-pull-request-title.yml
job still runs; therefore, please follow the steps described here to make sure it still works.What are the relevant tickets?
Resolves VIDCS-3252
[👎 ] Resolves a
Known Issue
.[ ] If yes, did you remove the item from the
docs/KNOWN_ISSUES.md
?[👍 ] Resolves an item reported in
Issues
.If yes, which issue?
[👍 ] If yes, did you close the item in
Issues
?