Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VIDCS-3252: Resolve GitHub Mend warnings for VERA #12

Merged
merged 2 commits into from
Jan 20, 2025

Conversation

behei-vonage
Copy link
Contributor

@behei-vonage behei-vonage commented Jan 15, 2025

What is this PR doing?

This PR resolves the 2 issues mentioned in the Issues tab:

#11

#10

How should this be manually tested?

We need to make sure that with these changes the check-pull-request-title.yml job still runs; therefore, please follow the steps described here to make sure it still works.

What are the relevant tickets?

Resolves VIDCS-3252

[👎 ] Resolves a Known Issue.
[ ] If yes, did you remove the item from the docs/KNOWN_ISSUES.md?
[👍 ] Resolves an item reported in Issues.
If yes, which issue?

Copy link
Collaborator

@dwivedisachin dwivedisachin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also Tested the PR LGTM!! 🚀

Copy link
Collaborator

@v-kpheng v-kpheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 💪 🚀

@@ -13,7 +16,7 @@ jobs:
set -e

pr_name="${{ github.event.pull_request.title }}"
echo "PR Title: '$pr_name'"
echo "PR Title: '${pr_name}'"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this is just for tech debt? 🤷‍♂️

Copy link
Contributor

@maikthomas maikthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maikthomas maikthomas merged commit 79d6631 into main Jan 20, 2025
6 checks passed
@maikthomas maikthomas deleted the behei-vonage/vidcs-3140-mend-yml-warnings branch January 20, 2025 15:53
@behei-vonage behei-vonage changed the title VIDCS-3140: Resolve GitHub Mend warnings for VERA VIDCS-3252: Resolve GitHub Mend warnings for VERA Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants