VIDCS-3254: Update ChatInput.tsx to fix message sent during composition #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed a bug that caused text to be incorrectly posted during conversion when using double-byte characters (e.g., Japanese).
maikthomas
changed the title
|
@mobilebiz thank you for your contribution! I am able to reproduce this bug and have created a ticket to track it on our side. We will validate the fix and will probably need to add an automated test, check our CI, and get this fix included as soon as possible. |
maikthomas
reviewed
Jan 23, 2025
There was a problem hiding this comment.
Thanks for adding the test @behei-vonage!
Please see the line I think can be removed 🙏
maikthomas
previously approved these changes
Jan 23, 2025
dwivedisachin
dismissed stale reviews from cpettet and maikthomas
The base branch was changed.
maikthomas
approved these changes
Jan 27, 2025
dwivedisachin
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a bug that caused text to be incorrectly posted during conversion when using double-byte characters (e.g., Japanese).
What is this PR doing?
A new variable,
isComposing, is created to hold the state of the conversion mode.The enter key is disabled during conversion.
Get the
onCompositionStartandonCompositionEndevents of the chat text field and change the state ofisComposing.How should this be manually tested?
Input double-byte characters in the chat field.
What are the relevant tickets?
Resolves VIDCS-3254