Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VIDCS-3224: sound.mp3 change localhost url to relative url #19

Merged
merged 2 commits into from
Jan 21, 2025

Conversation

maikthomas
Copy link
Contributor

What is this PR doing?

  • Fixes bug where sound.mp3 was trying to load from localhost and failing, breaking sound test

How should this be manually tested?

  • run locally, enter meeting room, open mic settings, click "Test Speakers"
  • in network tab check link is the same port as the page and not the api port

What are the relevant tickets?

Resolves VIDCS-3224

[ ] Resolves a Known Issue.
[ ] If yes, did you remove the item from the docs/KNOWN_ISSUES.md?
[ ] Resolves an item reported in Issues.
If yes, which issue? Issue Number?
[ ] If yes, did you close the item in Issues?

@maikthomas maikthomas changed the title VIDCS-3224 sound.mp3 change localhost url to relative url VIDCS-3224: sound.mp3 change localhost url to relative url Jan 21, 2025
Copy link
Contributor

@cpettet cpettet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Great job! :shipit:

@DeliaTok
Copy link

looks good

@behei-vonage behei-vonage merged commit 5ee2604 into main Jan 21, 2025
6 checks passed
@behei-vonage behei-vonage deleted the mthomas/VIDCS-3224-load-sound-test branch January 21, 2025 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants