Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VIDCS-3223: Fix audio option crash in android chrome - disable speaker test on android #21

Merged
merged 2 commits into from
Jan 22, 2025

Conversation

maikthomas
Copy link
Contributor

What is this PR doing?

  • Removes sound test / speaker test option on android
  • This fixes a bug where opening mic audio device settings crashed the app because it tried to use setSinkId which is not supported
index-s-hJiPSy.js:40 TypeError: i.setSinkId is not a function
index-s-hJiPSy.js:1954 Uncaught TypeError: i.setSinkId is not a function
index-s-hJiPSy.js:620 OpenTok:NativeVideoElementWrapper:2:warn Video element paused, auto-resuming. If you intended to do this, use publishVideo(false) or subscribeToVideo(false) instead. +0ms
index-s-hJiPSy.js:1954 Uncaught (in promise) 
p {code: undefined, message: 'setAudioOutputDevice is not supported in your browser.', name: 'OT_UNSUPPORTED_BROWSER', stack: 'Error: setAudioOutputDevice is not supported in yo…/localhost:3345/assets/index-s-hJiPSy.js:81:7215)'}

How should this be manually tested?

STR and STVerify fix

  • open the app on android chrome
  • join a room
  • click the mic options button
  • observe crash

What are the relevant tickets?

Resolves VIDCS-3223

[ ] Resolves a Known Issue.
[ ] If yes, did you remove the item from the docs/KNOWN_ISSUES.md?
[ ] Resolves an item reported in Issues.
If yes, which issue? Issue Number?
[ ] If yes, did you close the item in Issues?

Copy link
Contributor

@behei-vonage behei-vonage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@cpettet cpettet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Great job! :shipit:

@dwivedisachin
Copy link
Collaborator

Tested LGTM!! 🚀

@dwivedisachin dwivedisachin merged commit 0ccf195 into main Jan 22, 2025
7 checks passed
@dwivedisachin dwivedisachin deleted the mthomas/VIDCS-3223-fix-audio-options-android branch January 22, 2025 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants