Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VIDCS-3247: Stop VERA instance being indexed #22

Merged
merged 2 commits into from
Jan 22, 2025

Conversation

behei-vonage
Copy link
Contributor

What is this PR doing?

This PR adds an instruction to our express server to not be indexed by the search engines.

How should this be manually tested?

Checkout this branch locally.
Run the backend by doing yarn start:backend
Run curl -I http://localhost:3345
Make sure the following tag is present:

X-Robots-Tag: noindex, nofollow

What are the relevant tickets?

Resolves VIDCS-3247

[👎 ] Resolves a Known Issue.
[ ] If yes, did you remove the item from the docs/KNOWN_ISSUES.md?
[👎 ] Resolves an item reported in Issues.
If yes, which issue? Issue Number?
[ ] If yes, did you close the item in Issues?

@behei-vonage behei-vonage self-assigned this Jan 21, 2025
Copy link
Contributor

@cpettet cpettet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Great job! :shipit:

Copy link
Contributor

@maikthomas maikthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@@ -19,6 +19,12 @@ app.use(bodyParser.json());
app.set('trust proxy', true);
app.use(router);

app.use((req, res, next) => {
// This is needed to remove the deployed application from being indexed by Search engines
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: comment could do with rewording

@dwivedisachin
Copy link
Collaborator

Tested LGTM!! 🚀

@behei-vonage behei-vonage merged commit af1d966 into main Jan 22, 2025
7 checks passed
@behei-vonage behei-vonage deleted the behei-vonage/vidcs-3247-index branch January 22, 2025 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants