VIDCS-2175: Should mitigate against publisher failures via permissions, hardware, or network failures by automatically retrying. (no ghost viewers, if retrying doesn’t work we fail)) #38
+354
−32
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR doing?
Description
Currently, denying device permissions in the waiting room displays a prompt to change device permissions access. In the meeting room, denying device permissions destroys the publisher without notifying the user why.
After a Slack UX (or maybe it was during standup) review last year, we chose to redirect users to the
goodbye
page if they deny device permissions in the meeting room and to display an error message. To make it easier for our users, changing device permissions in the waiting room will force a page reload.There's also a bit of light refactoring, a whole 'nother test file 🙃, and some additional unit tests.
Some screens of fixes
How should this be manually tested?
Repro'ing the issue
Testing the fix
Testing waiting room changes
Testing meeting room changes
What are the relevant tickets?
Resolves VIDCS-2175
[ ] Resolves a
Known Issue
.[ ] If yes, did you remove the item from the
docs/KNOWN_ISSUES.md
?[ ] Resolves an item reported in
Issues
.If yes, which issue? Issue Number?
[ ] If yes, did you close the item in
Issues
?