VIDCS-3205: Fix deps security issues with resolutions #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maikthomas
commented
Jan 14, 2025
Comment on lines
+74
to
+81
| "wrap-ansi": "7.0.0", | ||
| "path-to-regexp": "^0.1.12", | ||
| "express": "^4.21.2", | ||
| "axios": "^1.7.4", | ||
| "cross-spawn": "^7.0.5", | ||
| "rollup": "^4.22.4", | ||
| "vite": "^5.4.11", | ||
| "nanoid": "^3.3.8" |
There was a problem hiding this comment.
Unfortunately we have dependencies that do not have a compatible version which updates these internal dependencies so we have to use yarn resolutions to override those versions instead.
maikthomas
changed the title
maikthomas
commented
Jan 14, 2025
Comment on lines
135
to
137
| await pageOne.waitForSelector('.publisher', { state: 'visible' }); | ||
| await pageTwo.waitForSelector('.subscriber', { state: 'visible' }); | ||
| const screenshareButton = await pageOne.getByTestId('ScreenShareIcon'); |
There was a problem hiding this comment.
I think this was failing sometimes because we weren't connected so the screenshare button wasn't available yet.
For now this fix waits until a subscriber is visible for tab 2 which means we're obviously already connected and publishing & subscribing - then starts screensharing from page one
|
since the relevant CI checks pass I will merge this PR in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR doing?
How should this be manually tested?
What are the relevant tickets?
Resolves VIDCS-3205
[ ] Resolves a
Known Issue.[ ] If yes, did you remove the item from the
docs/KNOWN_ISSUES.md?[ ] Resolves an item reported in
Issues.If yes, which issue? Issue Number?
[ ] If yes, did you close the item in
Issues?