Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade releases and packages for meteor 1.10.2 #170

Closed
wants to merge 1 commit into from

Conversation

TomFreudenberg
Copy link

based on the work in issue #167 this are the necessary changes to run with meteor 1.10.2 and node 12

@TomFreudenberg
Copy link
Author

TomFreudenberg commented Apr 30, 2020

This works as described in https://docs.vulcanjs.org/#Two-Repo-Install-Optional

git clone -b devel Vulcan
git clone -b master Vulcan-Starter
cd Vulcan-Starter
cp sample-settings.json settings.json
METEOR_PACKAGE_DIRS="../Vulcan/packages" meteor npm install
METEOR_PACKAGE_DIRS="../Vulcan/packages" meteor --port 3000 --settings settings.json

Browse localhost:3000

@eric-burel
Copy link
Collaborator

Awesome! I will keep your PR around until next release, I've manually made the minimal changes based on it, it now should work on "master" branch of the Starter and on "devel + Vulcan on devel".

  • The Starter master branch should work at any time, with a 1-repo install. It is now ok with Meteor 1.10 on my side.

  • The Starter devel branch should work with a 2-repo install and Vulcan on devel, but it may be a bit broken from time to time, especially when we update NPM package. That's ok, because it's a devel branch. The fix is often slightly changing some syntax or versions, never a huge issue.

I will then include your additional changes manually during the release.

Thanks a lot for your contrib and not giving up against install error, keeping everything up to date is always a fight and that helps a lot.

@eric-burel eric-burel closed this May 9, 2020
@eric-burel
Copy link
Collaborator

It will be included in next release. Feel free to include other change in another separate PR if you want (eg adding Husky etc.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants