Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Round up to nearest tenths place for information gain limit for event-level navigations #1132

Merged
merged 6 commits into from
Jan 3, 2024
Merged

Round up to nearest tenths place for information gain limit for event-level navigations #1132

merged 6 commits into from
Jan 3, 2024

Conversation

akashnadan
Copy link
Collaborator

@akashnadan akashnadan commented Jan 2, 2024 •
edited
Loading

Clarification of information gain limit for event-level navigations. Information gain has been rounded to the nearest tenths place (11.46 to 11.5) to match the rounding of event-level views

@akashnadan akashnadan marked this pull request as ready for review January 2, 2024 18:56
@akashnadan akashnadan requested a review from apasel422 January 2, 2024 18:56
apasel422
apasel422 requested changes Jan 2, 2024
View reviewed changes
Copy link
Collaborator

@apasel422 apasel422 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's give the PR a more meaningful title, since this isn't really a clarification. Perhaps Raise Chromium's max navigation info gain from 11.46 to 11.5?

@akashnadan akashnadan changed the title Clarification of information gain limits for flexible event-level Round up information gain limit for flexible event-level navigations Jan 2, 2024
@akashnadan akashnadan changed the title Round up information gain limit for flexible event-level navigations Round up to nearest tenths place for information gain limit for flexible event-level navigations Jan 2, 2024
@akashnadan akashnadan requested a review from apasel422 January 2, 2024 19:39
apasel422
apasel422 requested changes Jan 2, 2024
View reviewed changes
Copy link
Collaborator

@apasel422 apasel422 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding the PR title, the "flexible" part is irrelevant. This will be the max event-level info gain for all navigation sources.

@akashnadan akashnadan changed the title Round up to nearest tenths place for information gain limit for flexible event-level navigations Round up to nearest tenths place for information gain limit for event-level navigations Jan 2, 2024
@akashnadan akashnadan requested a review from apasel422 January 2, 2024 19:44
@akashnadan akashnadan merged commit c39ac5e into main Jan 3, 2024
1 check passed
@akashnadan akashnadan deleted the akashnadan-patch-4 branch January 3, 2024 17:12
aarongable pushed a commit to chromium/chromium that referenced this pull request Jan 3, 2024
Raise max navigation-source info gain to 11.5
f470a17 
WICG/attribution-reporting-api#1132

Change-Id: I8590941402435c51dc8c3ac2cbb27fb5c63517f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5160091
Commit-Queue: Andrew Paseltiner <[email protected]>
Reviewed-by: Charlie Harrison <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1242613}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apasel422 apasel422 apasel422 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akashnadan @apasel422