Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up fake report generation #1135

Merged
merged 4 commits into from
Jan 4, 2024

Conversation

linnan-github
Copy link
Collaborator

@linnan-github linnan-github commented Jan 4, 2024

Many fields in the trigger is irrelevant of event-level report generation. Removed fakeTrigger and passed the corresponding fields into the algorithm.


Preview | Diff

@apasel422
Copy link
Collaborator

I don't think this is correct. Per the Chromium link, it's only the context origin that is set that way, not the actual attribution destinations.

@linnan-github
Copy link
Collaborator Author

I don't think this is correct. Per the Chromium link, it's only the context origin that is set that way, not the actual attribution destinations.

Yeah the fake trigger's destination is not actually not used for the event-level report, but I feel it's easier to understand.

BTW, this needs to be fixed anyways as the destination is a list.

@linnan-github linnan-github changed the title Fix fake report's destination to source site Fix fake trigger's destination to source site Jan 4, 2024
@linnan-github linnan-github changed the title Fix fake trigger's destination to source site Fix fake trigger's attribution destination to source site Jan 4, 2024
@apasel422
Copy link
Collaborator

Yeah the fake trigger's destination is not actually not used for the event-level report, but I feel it's easier to understand.

I disagree: The context origin only really exists as a concept in the Chromium implementation, as it's needed strictly for data deletion and browser policy.

BTW, this needs to be fixed anyways as the destination is a list.

You're right, but maybe the better approach is to stop generating a fake trigger at all in the spec.

Co-authored-by: Andrew Paseltiner <[email protected]>
@linnan-github
Copy link
Collaborator Author

Yeah the fake trigger's destination is not actually not used for the event-level report, but I feel it's easier to understand.

I disagree: The context origin only really exists as a concept in the Chromium implementation, as it's needed strictly for data deletion and browser policy.

BTW, this needs to be fixed anyways as the destination is a list.

You're right, but maybe the better approach is to stop generating a fake trigger at all in the spec.

Yeah that's fair. Maybe we can update "obtain an event-level report" algorithm to take trigger time and trigger debug key instead of a trigger.

@linnan-github linnan-github changed the title Fix fake trigger's attribution destination to source site Clean up fake report generation Jan 4, 2024
@linnan-github linnan-github merged commit 4661b99 into WICG:main Jan 4, 2024
1 check passed
@linnan-github linnan-github deleted the fixFakeReportDestination branch January 4, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants