-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up fake report generation #1135
Clean up fake report generation #1135
Conversation
I don't think this is correct. Per the Chromium link, it's only the context origin that is set that way, not the actual attribution destinations. |
Yeah the fake trigger's destination is not actually not used for the event-level report, but I feel it's easier to understand. BTW, this needs to be fixed anyways as the destination is a list. |
I disagree: The context origin only really exists as a concept in the Chromium implementation, as it's needed strictly for data deletion and browser policy.
You're right, but maybe the better approach is to stop generating a fake trigger at all in the spec. |
Co-authored-by: Andrew Paseltiner <[email protected]>
Yeah that's fair. Maybe we can update "obtain an event-level report" algorithm to take trigger time and trigger debug key instead of a trigger. |
Many fields in the trigger is irrelevant of event-level report generation. Removed fakeTrigger and passed the corresponding fields into the algorithm.
Preview | Diff