Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix inconsistencies in max event-level channel capacity usage #1168

Merged
merged 1 commit into from
Feb 28, 2024
Merged

Fix inconsistencies in max event-level channel capacity usage #1168

merged 1 commit into from
Feb 28, 2024

Conversation

apasel422
Copy link
Collaborator

@apasel422 apasel422 commented Feb 20, 2024 •
edited by pr-preview bot
Loading

  • Replace integer with double in spec, as implementations are already using fractional values
  • Replace "information gain" with "event-level channel capacity" in Chromium's param listing, since the latter is the terminology used by the spec

Preview | Diff

@apasel422
Fix inconsistencies in max event-level channel capacity usage
802557c 
- Replace integer with double in spec, as implementations are already
  using fractional values
- Replace "information gain" with "event-level channel capacity" in
  Chromium's param listing, since the latter is the terminology used by
  the spec
@apasel422 apasel422 marked this pull request as ready for review February 20, 2024 14:56
@apasel422 apasel422 requested a review from csharrison February 20, 2024 14:56
@apasel422 apasel422 merged commit 6c86af5 into WICG:main Feb 28, 2024
2 checks passed
@apasel422 apasel422 deleted the types branch February 28, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csharrison csharrison csharrison approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@apasel422 @csharrison