Move time-based destination limit check later #1170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please motivate the security concerns a bit better in the PR description? |
|
@arpanah Could you please take a look as well? Thanks. |
Updated, PTAL, thanks! |
|
Can we add an interop test that demonstrates this? |
|
@ddworken FYI as well, thanks! |
csharrison
approved these changes
Feb 27, 2024
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Feb 28, 2024
WICG/attribution-reporting-api#1170 Change-Id: I8092cc311691f166c3c7f0b07280a9b588fa6832 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5318269 Reviewed-by: Andrew Paseltiner <[email protected]> Cr-Commit-Position: refs/heads/main@{#1266373}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We only report the first encountered error in the attribution registration.
To better mitigate security concerns on the global destination limit, moving the check later so that whether the limit is actually hit cannot be inferred from the presence of other explicitly reported errors.
Preview | Diff