Aggregatable Contribution Named Budget #1422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feifeiji89
force-pushed
the
cap
branch
6 times, most recently
from
b019735 to
db61bf4
Compare
feifeiji89
changed the title
feifeiji89
force-pushed
the
cap
branch
2 times, most recently
from
5e29ff6 to
b0d9c76
Compare
apasel422
requested changes
Sep 16, 2024
apasel422
requested changes
Sep 16, 2024
linnan-github
requested changes
Sep 16, 2024
linnan-github
requested changes
Sep 17, 2024
apasel422
requested changes
Sep 17, 2024
linnan-github
requested changes
Sep 19, 2024
linnan-github
requested changes
Oct 4, 2024
linnan-github
requested changes
Oct 7, 2024
|
Please resolve the merge conflicts as well, thanks. |
linnan-github
requested changes
Oct 10, 2024
akashnadan
reviewed
Oct 10, 2024
akashnadan
reviewed
Oct 10, 2024
apasel422
requested changes
Oct 11, 2024
apasel422
reviewed
Oct 11, 2024
apasel422
requested changes
Oct 11, 2024
apasel422
approved these changes
Oct 14, 2024
|
I'm not extremely familiar with the background of this change, so sorry if this is a silly question, but is there any use case for contributing to multiple buckets simultaneously? |
feifeiji89
changed the title
apasel422
requested changes
Oct 15, 2024
apasel422
approved these changes
Oct 16, 2024
apasel422
reviewed
Oct 16, 2024
linnan-github
approved these changes
Oct 16, 2024
apasel422
requested changes
Oct 29, 2024
apasel422
requested changes
Nov 4, 2024
Co-authored-by: Andrew Paseltiner <[email protected]>
apasel422
reviewed
Nov 4, 2024
Co-authored-by: Andrew Paseltiner <[email protected]>
apasel422
approved these changes
Nov 4, 2024
akashnadan
approved these changes
Nov 4, 2024
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Nov 6, 2024
WICG/attribution-reporting-api#1422 This CL modifies source and trigger registration parsing to include the aggregatable named budget field. BYPASS_LARGE_CHANGE_WARNING Bug: 369865063 Change-Id: I2fc4ea270babb6715dbb70a50c7c07833ff77c9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5893006 Reviewed-by: Nan Lin <[email protected]> Commit-Queue: Thomas Quintanilla <[email protected]> Reviewed-by: Dominic Farolino <[email protected]> Reviewed-by: Andrew Paseltiner <[email protected]> Cr-Commit-Position: refs/heads/main@{#1378770}
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Nov 6, 2024
WICG/attribution-reporting-api#1422 A debug report is sent when an aggregatable contribution exceeds the associated named budget value. Utilizes out params to transfer needed report data from storage to debug report creation. A potential refactor can include change the return type of `MaybeStoreAggregatableAttributionReportData` to a `CreateReportResult` to avoid such out params. Bug: 369865063 Change-Id: Ia1d01f75355f7b2faf3bc746ee1ca2d34fa02d55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5957125 Reviewed-by: Dominic Farolino <[email protected]> Reviewed-by: John Delaney <[email protected]> Reviewed-by: Nan Lin <[email protected]> Commit-Queue: Thomas Quintanilla <[email protected]> Reviewed-by: Andrew Paseltiner <[email protected]> Reviewed-by: Andrey Kosyakov <[email protected]> Cr-Commit-Position: refs/heads/main@{#1379006}
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Nov 6, 2024
WICG/attribution-reporting-api#1422 Tests more complex interactions involving multiple named budgets and filters. Bug: 369865063 Change-Id: I73cec5ed92bac54689c169577273785174cd0af2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5976521 Reviewed-by: Andrew Paseltiner <[email protected]> Commit-Queue: Thomas Quintanilla <[email protected]> Reviewed-by: Nan Lin <[email protected]> Cr-Commit-Position: refs/heads/main@{#1379019}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently Adtechs can't control L1 budget allocation for different conversion types / SDKs through the current Aggregate API, such as:
We can optionally support these use-cases by allowing callers of the API to specify max budget for predefined buckets that will be considered at aggregate report generation time.
Preview | Diff