Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ar_debug requirement for cookie-based debug reporting #1441

Merged
merged 5 commits into from
Oct 15, 2024

Conversation

linnan-github
Copy link
Collaborator

@linnan-github linnan-github commented Sep 24, 2024

Fixes #1440


Preview | Diff

Copy link
Collaborator

@akashnadan akashnadan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor edits to debugging wording

Copy link
Contributor

@johnivdel johnivdel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Co-authored-by: Andrew Paseltiner <[email protected]>
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Oct 11, 2024
WICG/attribution-reporting-api#1441

Bug: 369506940, 330745162
Change-Id: I1dfc23f96e9d7a594c23114ad707ceffcde1161e
Co-authored-by: Andrew Paseltiner <[email protected]>
@linnan-github linnan-github merged commit c69906a into WICG:main Oct 15, 2024
2 checks passed
@linnan-github linnan-github deleted the removeArDebug branch October 15, 2024 12:58
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Oct 15, 2024
WICG/attribution-reporting-api#1441

Bug: 369506940, 330745162
Change-Id: I1dfc23f96e9d7a594c23114ad707ceffcde1161e
aarongable pushed a commit to chromium/chromium that referenced this pull request Oct 15, 2024
WICG/attribution-reporting-api#1441

Bug: 369506940, 330745162
Change-Id: I1dfc23f96e9d7a594c23114ad707ceffcde1161e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5887664
Reviewed-by: Andrew Paseltiner <[email protected]>
Commit-Queue: Nan Lin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1368833}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Oct 15, 2024
WICG/attribution-reporting-api#1441

Bug: 369506940, 330745162
Change-Id: I1dfc23f96e9d7a594c23114ad707ceffcde1161e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5887664
Reviewed-by: Andrew Paseltiner <[email protected]>
Commit-Queue: Nan Lin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1368833}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Oct 15, 2024
WICG/attribution-reporting-api#1441

Bug: 369506940, 330745162
Change-Id: I1dfc23f96e9d7a594c23114ad707ceffcde1161e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5887664
Reviewed-by: Andrew Paseltiner <[email protected]>
Commit-Queue: Nan Lin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1368833}
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Oct 18, 2024
…ased debug reporting, a=testonly

Automatic update from web-platform-tests
Remove ar_debug requirement for cookie-based debug reporting

WICG/attribution-reporting-api#1441

Bug: 369506940, 330745162
Change-Id: I1dfc23f96e9d7a594c23114ad707ceffcde1161e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5887664
Reviewed-by: Andrew Paseltiner <[email protected]>
Commit-Queue: Nan Lin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1368833}

--

wpt-commits: 7275b2c6bf4b9312a1945a451a5333e8922ee524
wpt-pr: 48578
ErichDonGubler pushed a commit to erichdongubler-mozilla/firefox that referenced this pull request Oct 21, 2024
…ased debug reporting, a=testonly

Automatic update from web-platform-tests
Remove ar_debug requirement for cookie-based debug reporting

WICG/attribution-reporting-api#1441

Bug: 369506940, 330745162
Change-Id: I1dfc23f96e9d7a594c23114ad707ceffcde1161e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5887664
Reviewed-by: Andrew Paseltiner <[email protected]>
Commit-Queue: Nan Lin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1368833}

--

wpt-commits: 7275b2c6bf4b9312a1945a451a5333e8922ee524
wpt-pr: 48578
i3roly pushed a commit to i3roly/firefox-dynasty that referenced this pull request Oct 22, 2024
…ased debug reporting, a=testonly

Automatic update from web-platform-tests
Remove ar_debug requirement for cookie-based debug reporting

WICG/attribution-reporting-api#1441

Bug: 369506940, 330745162
Change-Id: I1dfc23f96e9d7a594c23114ad707ceffcde1161e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5887664
Reviewed-by: Andrew Paseltiner <[email protected]>
Commit-Queue: Nan Lin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1368833}

--

wpt-commits: 7275b2c6bf4b9312a1945a451a5333e8922ee524
wpt-pr: 48578
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request Oct 22, 2024
…ased debug reporting, a=testonly

Automatic update from web-platform-tests
Remove ar_debug requirement for cookie-based debug reporting

WICG/attribution-reporting-api#1441

Bug: 369506940, 330745162
Change-Id: I1dfc23f96e9d7a594c23114ad707ceffcde1161e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5887664
Reviewed-by: Andrew Paseltiner <apaseltinerchromium.org>
Commit-Queue: Nan Lin <linnanchromium.org>
Cr-Commit-Position: refs/heads/main{#1368833}

--

wpt-commits: 7275b2c6bf4b9312a1945a451a5333e8922ee524
wpt-pr: 48578

UltraBlame original commit: 687cadc2e52e041672607584874f277e7e87dae7
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request Oct 22, 2024
…ased debug reporting, a=testonly

Automatic update from web-platform-tests
Remove ar_debug requirement for cookie-based debug reporting

WICG/attribution-reporting-api#1441

Bug: 369506940, 330745162
Change-Id: I1dfc23f96e9d7a594c23114ad707ceffcde1161e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5887664
Reviewed-by: Andrew Paseltiner <apaseltinerchromium.org>
Commit-Queue: Nan Lin <linnanchromium.org>
Cr-Commit-Position: refs/heads/main{#1368833}

--

wpt-commits: 7275b2c6bf4b9312a1945a451a5333e8922ee524
wpt-pr: 48578

UltraBlame original commit: 687cadc2e52e041672607584874f277e7e87dae7
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request Oct 22, 2024
…ased debug reporting, a=testonly

Automatic update from web-platform-tests
Remove ar_debug requirement for cookie-based debug reporting

WICG/attribution-reporting-api#1441

Bug: 369506940, 330745162
Change-Id: I1dfc23f96e9d7a594c23114ad707ceffcde1161e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5887664
Reviewed-by: Andrew Paseltiner <apaseltinerchromium.org>
Commit-Queue: Nan Lin <linnanchromium.org>
Cr-Commit-Position: refs/heads/main{#1368833}

--

wpt-commits: 7275b2c6bf4b9312a1945a451a5333e8922ee524
wpt-pr: 48578

UltraBlame original commit: 687cadc2e52e041672607584874f277e7e87dae7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants