-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove ar_debug requirement for cookie-based debug reporting #1441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akashnadan
reviewed
Oct 1, 2024
akashnadan
reviewed
Oct 1, 2024
akashnadan
reviewed
Oct 1, 2024
akashnadan
previously requested changes
Oct 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor edits to debugging wording
Co-authored-by: Akash Nadan <[email protected]>
johnivdel
approved these changes
Oct 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
apasel422
approved these changes
Oct 11, 2024
Co-authored-by: Andrew Paseltiner <[email protected]>
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Oct 11, 2024
WICG/attribution-reporting-api#1441 Bug: 369506940, 330745162 Change-Id: I1dfc23f96e9d7a594c23114ad707ceffcde1161e
apasel422
approved these changes
Oct 14, 2024
Co-authored-by: Andrew Paseltiner <[email protected]>
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Oct 15, 2024
WICG/attribution-reporting-api#1441 Bug: 369506940, 330745162 Change-Id: I1dfc23f96e9d7a594c23114ad707ceffcde1161e
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Oct 15, 2024
WICG/attribution-reporting-api#1441 Bug: 369506940, 330745162 Change-Id: I1dfc23f96e9d7a594c23114ad707ceffcde1161e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5887664 Reviewed-by: Andrew Paseltiner <[email protected]> Commit-Queue: Nan Lin <[email protected]> Cr-Commit-Position: refs/heads/main@{#1368833}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Oct 15, 2024
WICG/attribution-reporting-api#1441 Bug: 369506940, 330745162 Change-Id: I1dfc23f96e9d7a594c23114ad707ceffcde1161e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5887664 Reviewed-by: Andrew Paseltiner <[email protected]> Commit-Queue: Nan Lin <[email protected]> Cr-Commit-Position: refs/heads/main@{#1368833}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Oct 15, 2024
WICG/attribution-reporting-api#1441 Bug: 369506940, 330745162 Change-Id: I1dfc23f96e9d7a594c23114ad707ceffcde1161e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5887664 Reviewed-by: Andrew Paseltiner <[email protected]> Commit-Queue: Nan Lin <[email protected]> Cr-Commit-Position: refs/heads/main@{#1368833}
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Oct 18, 2024
…ased debug reporting, a=testonly Automatic update from web-platform-tests Remove ar_debug requirement for cookie-based debug reporting WICG/attribution-reporting-api#1441 Bug: 369506940, 330745162 Change-Id: I1dfc23f96e9d7a594c23114ad707ceffcde1161e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5887664 Reviewed-by: Andrew Paseltiner <[email protected]> Commit-Queue: Nan Lin <[email protected]> Cr-Commit-Position: refs/heads/main@{#1368833} -- wpt-commits: 7275b2c6bf4b9312a1945a451a5333e8922ee524 wpt-pr: 48578
ErichDonGubler
pushed a commit
to erichdongubler-mozilla/firefox
that referenced
this pull request
Oct 21, 2024
…ased debug reporting, a=testonly Automatic update from web-platform-tests Remove ar_debug requirement for cookie-based debug reporting WICG/attribution-reporting-api#1441 Bug: 369506940, 330745162 Change-Id: I1dfc23f96e9d7a594c23114ad707ceffcde1161e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5887664 Reviewed-by: Andrew Paseltiner <[email protected]> Commit-Queue: Nan Lin <[email protected]> Cr-Commit-Position: refs/heads/main@{#1368833} -- wpt-commits: 7275b2c6bf4b9312a1945a451a5333e8922ee524 wpt-pr: 48578
i3roly
pushed a commit
to i3roly/firefox-dynasty
that referenced
this pull request
Oct 22, 2024
…ased debug reporting, a=testonly Automatic update from web-platform-tests Remove ar_debug requirement for cookie-based debug reporting WICG/attribution-reporting-api#1441 Bug: 369506940, 330745162 Change-Id: I1dfc23f96e9d7a594c23114ad707ceffcde1161e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5887664 Reviewed-by: Andrew Paseltiner <[email protected]> Commit-Queue: Nan Lin <[email protected]> Cr-Commit-Position: refs/heads/main@{#1368833} -- wpt-commits: 7275b2c6bf4b9312a1945a451a5333e8922ee524 wpt-pr: 48578
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 22, 2024
…ased debug reporting, a=testonly Automatic update from web-platform-tests Remove ar_debug requirement for cookie-based debug reporting WICG/attribution-reporting-api#1441 Bug: 369506940, 330745162 Change-Id: I1dfc23f96e9d7a594c23114ad707ceffcde1161e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5887664 Reviewed-by: Andrew Paseltiner <apaseltinerchromium.org> Commit-Queue: Nan Lin <linnanchromium.org> Cr-Commit-Position: refs/heads/main{#1368833} -- wpt-commits: 7275b2c6bf4b9312a1945a451a5333e8922ee524 wpt-pr: 48578 UltraBlame original commit: 687cadc2e52e041672607584874f277e7e87dae7
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 22, 2024
…ased debug reporting, a=testonly Automatic update from web-platform-tests Remove ar_debug requirement for cookie-based debug reporting WICG/attribution-reporting-api#1441 Bug: 369506940, 330745162 Change-Id: I1dfc23f96e9d7a594c23114ad707ceffcde1161e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5887664 Reviewed-by: Andrew Paseltiner <apaseltinerchromium.org> Commit-Queue: Nan Lin <linnanchromium.org> Cr-Commit-Position: refs/heads/main{#1368833} -- wpt-commits: 7275b2c6bf4b9312a1945a451a5333e8922ee524 wpt-pr: 48578 UltraBlame original commit: 687cadc2e52e041672607584874f277e7e87dae7
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 22, 2024
…ased debug reporting, a=testonly Automatic update from web-platform-tests Remove ar_debug requirement for cookie-based debug reporting WICG/attribution-reporting-api#1441 Bug: 369506940, 330745162 Change-Id: I1dfc23f96e9d7a594c23114ad707ceffcde1161e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5887664 Reviewed-by: Andrew Paseltiner <apaseltinerchromium.org> Commit-Queue: Nan Lin <linnanchromium.org> Cr-Commit-Position: refs/heads/main{#1368833} -- wpt-commits: 7275b2c6bf4b9312a1945a451a5333e8922ee524 wpt-pr: 48578 UltraBlame original commit: 687cadc2e52e041672607584874f277e7e87dae7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1440
Preview | Diff