-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some fixes #20
Some fixes #20
Conversation
…tion returns aligned memory. Closes enzienaudio/hvcc#18
Overriding operator new for Heavy_{{name}} class, so that heap alloca…
Moving this to develop since that's where the work is happening :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to have to trust you on this as most of the hvcc internals are a complete mystery to me for I only have a superficial understanding.
I haven't even been able to test out all the features to be able to say what was broken on these midi objects, but proper midi handling sounds like a very nice improvement.
And since you seem to know what you're doing you are invited to help maintain this repo :) |
@giuliomoro can you fix the merge conflict and trigger a build? (you may need to move your repo to this orga first) When all good I'm happy to merge these (please double check on the midi fixes) |
Please go to #26 for a resolved state of the code in this PR (needs looking in to) |
Enabled noteout, ctlout, pgmout, touchout, bendout. Closes enzienaudio/hvcc#11
Fixed input ranges for MIDI out objects Closes enzienaudio/hvcc#13
Overriding operator new for Heavy_{{name}} class, so that heap allocation returns aligned memory. Closes enzienaudio/hvcc#18 (this would need more work and an exception should be thrown from the constructor if the alignment is wrong).