Set -fno-exceptions in CXXFLAGS #355
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems fairly reasonable. I wonder if this should be the default in clang? |
Not sure what it would involve but seems like a great idea to me. Would we still consider this PR in the meantime or focus on that? Also looks like will need #354 in for the CI |
|
Didn't get a response so am going to go ahead and close this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A while back, the idea to add no-exceptions to CXXFLAGS in the docker image came up but we held up to keep consistency with the cmake files
#271 (comment)
I thought it would be good to bring it up again with the cmake files also updated. AFAICT, when using wasi-sdk with C++ it almost always ends up the user's responsibility to set this as exceptions aren't supported, so it can be a bit easier by defaulting it