Add classes to IP addresses #5890
Conversation
Working with IP addresses or user agents can be challenging due to the difficulty in efficiently locating them. This pull request addresses this issue by introducing specific classes to the fields where these elements appear, making them readily accessible. For instance, you can now easily manipulate or retrieve these values using JavaScript, streamlining the process and enhancing performance. Additionally, there are scenarios, such as in the WBB/WSF (postIpAddress template), where applying this change could be beneficial or even necessary. However, for obvious reasons, those suggestions fall outside the scope of what I can propose in this context. :)
| @@ -226,7 +226,7 @@ | |||
| {if $user->getCurrentLocation()}<li>{@$user->getCurrentLocation()}</li>{/if} | |||
| {/if} | |||
| {if $__wcf->session->getPermission('admin.user.canViewIpAddress') && $user->registrationIpAddress} | |||
| <li>{lang}wcf.user.registrationIpAddress{/lang}: <span class="userRegistrationIpAddress">{@$user->getRegistrationIpAddress()|ipSearch}</span></li> | |||
| <li class="ipAddress">{lang}wcf.user.registrationIpAddress{/lang}: <span class="userRegistrationIpAddress">{@$user->getRegistrationIpAddress()|ipSearch}</span></li> | |||
There was a problem hiding this comment.
I've overseen that there is already a span with an appropriate class. However, adding a class to the surrounding element doesn't hurt :)
|
@dtdesign Any reason why? |
|
Sorry, I didn’t submit my message: This is a pretty generic class name and introducing it in a stable version can cause unwanted side effects in case that class name is already in use somewhere else (plugins, styles, etc.). We can add it to 6.1 though if you want. |
|
I just need a reliable way to manage IP addresses (and user agent strings) within the DOM. Instead of relying on complex and error-prone regex patterns, I prefer a more stable approach. The specific class name or data attribute used for this isn't critical, as long as it allows me to efficiently target and handle IP addresses (and user agent strings) selectively. |
Working with IP addresses or user agents can be challenging due to the difficulty in efficiently locating them. This pull request addresses this issue by introducing specific classes to the fields where these elements appear, making them readily accessible. For instance, you can now easily manipulate or retrieve these values using JavaScript, streamlining the process and enhancing performance.
Additionally, there are scenarios, such as in the WBB/WSF (postIpAddress template), where applying this change could be beneficial or even necessary. However, for obvious reasons, those suggestions fall outside the scope of what I can propose in this context. :)
This change is relatively minor and carries no risk of causing side effects. Therefore, it should be safe to merge.