Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update theme name in Gruntfile.js #216

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

felipeelia
Copy link
Member

This PR changes the theme name in Gruntfile.js, otherwise theme files won't be affected by grunt sass or grunt watch commands.

Seems to be related to #154.

@Clorith
Copy link
Member

Clorith commented May 22, 2018

It looks like you might have an old version of the directory, I'd recommend doing a pull first.

Also, theme-related stuff is already covered by the gruntfile in the theme directory, we should remove it from the root-gruntfile to avoid unexpected collisions or surprises.

@felipeelia
Copy link
Member Author

Sorry @Clorith. The file isn't that way here? I did a pull first...

And to use theme's Gruntfile we should update it's grunt-sass version, like was done in #197. The actual version didn't work for me (maybe it's too old?).

Sorry if am I not seeing something obvious here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants