Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix an issue where Modal focus was broken during minification #359

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

zusorio
Copy link
Contributor

@zusorio zusorio commented Jan 21, 2025

Closes #358

@totaam totaam merged commit bec4576 into Xpra-org:master Jan 21, 2025
1 check passed
@totaam
Copy link
Collaborator

totaam commented Jan 21, 2025

Great catch!

@zusorio zusorio deleted the focus-modal-fix branch January 21, 2025 12:29
@zusorio
Copy link
Contributor Author

zusorio commented Jan 21, 2025

Thanks! Can you trigger a beta build so we can try it out in production?

@totaam
Copy link
Collaborator

totaam commented Jan 21, 2025

Can you trigger a beta build so we can try it out in production?

I can't I am afraid, the single buildbot is still very busy making builds for the xpra 5.0.12 release: https://github.com/Xpra-org/xpra/releases/tag/v5.0.12
The arm64 and riscv64 take a lot of CPU time. It could take many more hours to complete.

@totaam
Copy link
Collaborator

totaam commented Jan 23, 2025

@zusorio not sure which distro you're interested in, but there are beta builds in progress now.

@zusorio
Copy link
Contributor Author

zusorio commented Jan 23, 2025

We're using debian bookworm

@totaam
Copy link
Collaborator

totaam commented Jan 23, 2025

We're using debian bookworm

Also done:

bookworm/main/binary-amd64/xpra-html5-17-r1696-1.deb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modal focus code behaves incorrectly when minified
2 participants