Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New general page: fix alert center notification breaking out of space #21730

Open
wants to merge 9 commits into
base: release/23.8
Choose a base branch
from

Conversation

igorschoester
Copy link
Member

Context

Summary

This PR can be summarized in the following changelog entry:

  • Fixes the alert center notifications breaking out of the space.
  • [@yoast/tailwindcss-preset 1.0.0 enhancement] Adds support for container queries via peer dependency @tailwindcss/container-queries.
  • [@yoast/ui-library 0.0.1 non-user-facing] Adds support for container queries via peer dependency @tailwindcss/container-queries from @yoast/tailwindcss-preset (unreleased version).

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • Use the test helper to reset your FTC progress, options and whatever is needed to get the notification with the Start SEO data optimization button, as show in the screenshot below
  • Enable the feature flag
  • Visit the General page
  • Play around with the screen width!
    Kapture 2024-10-21 at 17 07 37
  • Verify the problems/notifications stay at a reasonable width (container width > 768px to go next to eachother)
  • Verify the button for the FTC progress is no longer outside
  • Hide the FTC progress notification
  • Play around again
  • Verify the distances between and around the problems and notifications are now 24px instead of 32px
    Screenshot 2024-10-21 at 17 12 08

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes #21714

@igorschoester igorschoester added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label Oct 21, 2024
@igorschoester igorschoester requested a review from a team as a code owner October 21, 2024 15:19
* override the WP button style "white-space: nowrap" with "white-space: normal"
* rest is apply difference to align the comment and an auto-format
Looks better, approved by Kai
And while Kai was looking: spacing should be 24px instead of 32px
@igorschoester igorschoester force-pushed the 21714-new-general-page-alert-center-notification-breaking-out-of-space branch from 8f6bd4b to d7e7dc3 Compare October 22, 2024 10:29
@igorschoester igorschoester changed the base branch from trunk to release/23.8 October 22, 2024 10:29
@coveralls
Copy link

Pull Request Test Coverage Report for Build 3df72ca9e54bfc3b1c5c8da1d8dafc89026dc958

Details

  • 2 of 3 (66.67%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall first build on 21714-new-general-page-alert-center-notification-breaking-out-of-space at 27.067%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/js/src/general/routes/alert-center.js 0 1 0.0%
Totals Coverage Status
Change from base Build ec7d5157d74f2692a5b361b7ecc4597e790502c1: 27.1%
Covered Lines: 3799
Relevant Lines: 12905

💛 - Coveralls

Copy link
Contributor

@thijsoo thijsoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR 👍

@pls78
Copy link
Member

pls78 commented Oct 22, 2024

ACC: ✅
I have tiny doubt: you write: Verify the distances between and around the problems and notifications are now 24px instead of 32px, but I can see the padding between the alert center container and the page is still 32px. Did I misunderstood what you wrote? 🙁
Screenshot 2024-10-22 at 16 35 44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New General page: alert center notification breaking out of space
4 participants