-
Notifications
You must be signed in to change notification settings - Fork 890
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New general page: fix alert center notification breaking out of space #21730
Open
igorschoester
wants to merge
9
commits into
release/23.8
Choose a base branch
from
21714-new-general-page-alert-center-notification-breaking-out-of-space
base: release/23.8
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
New general page: fix alert center notification breaking out of space #21730
igorschoester
wants to merge
9
commits into
release/23.8
from
21714-new-general-page-alert-center-notification-breaking-out-of-space
+529
−570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igorschoester
added
the
changelog: non-user-facing
Needs to be included in the 'Non-userfacing' category in the changelog
label
Oct 21, 2024
* override the WP button style "white-space: nowrap" with "white-space: normal" * rest is apply difference to align the comment and an auto-format
See: https://github.com/tailwindlabs/tailwindcss-container-queries BREAKING CHANGE: added peer dependency
* needed to work with the updated tailwindcss-preset * https://github.com/tailwindlabs/tailwindcss-container-queries
Looks better, approved by Kai
And while Kai was looking: spacing should be 24px instead of 32px
igorschoester
force-pushed
the
21714-new-general-page-alert-center-notification-breaking-out-of-space
branch
from
October 22, 2024 10:29
8f6bd4b
to
d7e7dc3
Compare
Pull Request Test Coverage Report for Build 3df72ca9e54bfc3b1c5c8da1d8dafc89026dc958Details
💛 - Coveralls |
thijsoo
approved these changes
Oct 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
changelog: non-user-facing
Needs to be included in the 'Non-userfacing' category in the changelog
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Summary
This PR can be summarized in the following changelog entry:
@tailwindcss/container-queries
.@tailwindcss/container-queries
from@yoast/tailwindcss-preset
(unreleased version).Relevant technical choices:
Test instructions
Test instructions for the acceptance test before the PR gets merged
This PR can be acceptance tested by following these steps:
Start SEO data optimization
button, as show in the screenshot belowRelevant test scenarios
Test instructions for QA when the code is in the RC
QA can test this PR by following these steps:
Impact check
This PR affects the following parts of the plugin, which may require extra testing:
UI changes
Other environments
[shopify-seo]
, added test instructions for Shopify and attached theShopify
label to this PR.Documentation
Quality assurance
Innovation
innovation
label.Fixes #21714