[pull] main from zed-industries:main #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
Release Notes: - N/A
Release Notes: - N/A --------- Co-authored-by: Danilo Leal <[email protected]>
…24114) In the left hand status bar, there are two groups of buttons. There was a border between the two hardcoded on the first button of the second group, however, if all buttons in the first group are hidden, the border doesn't need to be rendered. (Not handled in this PR) A potentially better approach would be to change StatusBar's definition from `left_items` and `right_items` to `left_groups` and `right_groups`, and render dividers between each group of items. That seemed like a bigger refactor than I wanted to handle for now, but is an option for the future. If you use these settings on `main`, the border will show, but with nothing to the left of it. ```json { "collaboration_panel": { "button": false }, "outline_panel": { "button": false }, "project_panel": { "button": false, }, } ``` Screenshots: Before: <img width="117" alt="Screenshot 2025-02-02 at 6 19 24 PM" src="https://github.com/user-attachments/assets/b3401b47-6172-4392-9277-31aa1affaf7a" /> <img width="134" alt="Screenshot 2025-02-02 at 6 20 12 PM" src="https://github.com/user-attachments/assets/1e8caee6-1da8-47f6-8499-9a93b6d8fa27" /> After: <img width="125" alt="Screenshot 2025-02-02 at 6 19 58 PM" src="https://github.com/user-attachments/assets/9b9f421c-660b-41cb-80e0-acb774c66054" /> <img width="132" alt="Screenshot 2025-02-02 at 6 20 20 PM" src="https://github.com/user-attachments/assets/87e0e475-084b-44df-b820-573c68728c1a" /> Release Notes: - Conditionally render divider in status bar --------- Co-authored-by: Danilo Leal <[email protected]>
… typo (#24118) Release Notes: - N/A
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )