Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the relation between edits and neighbourhoods a bit more clear #97

Merged
merged 3 commits into from
Jan 24, 2025

Conversation

dabreegster
Copy link
Collaborator

Addresses the obvious fixes from #77.

  1. Internal code rename to match UI
  2. When you initially load a savefile, the user now can't "undo" all of the edits in it
  3. When switching neighbourhoods, the undo/redo lists clear, so the user can't accidentally modify something far away
  4. Pick neighbourhood mode summarizes the edits
    image

@@ -79,6 +80,26 @@
);
}

function countEdits(gj: FeatureCollection): {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Being sloppier, we'd just have a mapping from string to a counter (auto-set to 0) per kind property, but I couldn't get this all nicely working with TS, so verbose for now

{#if $mode.mode == "network"}
<NetworkMode />
{#if $mode.mode == "pick-neighbourhood"}
<PickNeighbourhoodMode />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay! better name!

@@ -90,7 +90,7 @@
</script>

<div class="pico">
<About class="pico" />
<About />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoops, thanks!

@dabreegster dabreegster merged commit 53170d2 into main Jan 24, 2025
@dabreegster dabreegster deleted the edits branch January 24, 2025 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants