r3.showdspf: fix null pointer dereference when opening database file (O…

…SGeo#4245) r3.showdspf: fix null pointer dereference In the current execution, when we face an error while trying to open a database file, as part of error log we are dereferencing a NULL file pointer (which is returend when we try to open a file). Ideally we should be printing the name of the database file rather than the file pointer. This fixes the problem of null pointer dereference. Found via cppcheck tool. Signed-off-by: Mohan Yelugoti <[email protected]>
a0x8o · Sep 5, 2024 · 10e1a3f · 10e1a3f
1 parent d368b54
commit 10e1a3f
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/raster3d/r3.showdspf/main_ogl.c b/raster3d/r3.showdspf/main_ogl.c
@@ -202,8 +202,7 @@ int main(int argc, char **argv)
             G_fatal_error(buff);
         }
         if ((Headfax.dspfinfp = G_fopen_old(buff, dsp, mapset)) == NULL) {
-            fprintf(stderr, "Unable to open <%s> for reading\n",
-                    Headfax.dspfinfp);
+            fprintf(stderr, "Unable to open <%s> for reading\n", dsp);
             exit(EXIT_FAILURE);
         }