Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Gulp in Favor of NPM CLI #1141

Open
wants to merge 25 commits into
base: main
Choose a base branch
from
Open

Remove Gulp in Favor of NPM CLI #1141

wants to merge 25 commits into from

Conversation

esjay
Copy link
Contributor

@esjay esjay commented Oct 27, 2020

In this PR, per Issue #989, we remove all traces of Gulp in favor of all NPM scripts for both development and build phases. We leverage new CLI-compliant NPM packages where necessary to provide cross-platform compatibility for non-unix-shell environments.

@esjay
Copy link
Contributor Author

esjay commented Feb 16, 2021

putting this work on hold until #989 is addressed at the eleventy is in a better place with incremental build

@ericwbailey ericwbailey mentioned this pull request Apr 26, 2021
@ericwbailey ericwbailey mentioned this pull request Nov 21, 2021
3 tasks
@ericwbailey ericwbailey mentioned this pull request May 10, 2023
20 tasks
@SaptakS SaptakS self-assigned this Aug 30, 2023
@nchan0154
Copy link
Contributor

nchan0154 commented Sep 7, 2023

Hi @esjay do you have any further interest in working on this? I was looking into upgrading to 11ty v2 first before seeing if we could merge this, but I think due to the nature of how entwined these changes are, I think we need to do both of these changes at the same time. Let us know if you would still be interested in tackling this.

It should be a smooth upgrade to v2, the Eleventy Upgrade help plugin (https://github.com/11ty/eleventy-upgrade-help) shows no errors that we need to deal with.

@nchan0154
Copy link
Contributor

nchan0154 commented Oct 3, 2023

Upgraded all the dependencies using the great base that Wayne has given us, and now the build does actually run well with Eleventy's incremental watching. I need to compare the site side by side and make sure everything still works, and double check that all the options to our new dependencies are valid/not deprecated. I also need to test whether or not the site builds in Windows (outside of WSL), as this an issue reported by previous contributors.

@nchan0154
Copy link
Contributor

nchan0154 commented Jan 24, 2024

(As always, apologies for coming back to this so late.)
I've tested the site side by side and it looks good. However, I'm running into some issues with Windows compatibility. There's lots of references to things that don't work on Windows, eg.

  • svgo \"dist/img/**/*.svg\" Glob syntax doesn't work in windows
  • mkdir -p Mkdir does work on windows, but the -p flag doesn't. I've tested it with npx mkdirp and it does work.
  • mv and rm don't work either

I'm wondering what you all feel the best path forwards is. Personally, I do like the idea of keeping it lean with npm scripts, but once we start using npx to pull in random packages for that cross system goodness, we end up creating our own little monster that may be harder than just using something like Vite, which 11ty now supports. Of course, we can leave it as it is and put a note in the readme that Windows users will have to use WSL, but I'd prefer to support as many environments as possible in order to create a more welcoming and inclusive environment for contributors.

Open to thoughts and suggestions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants