Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solid Principles have been added #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

codenim34
Copy link

I have seen your code. Then for my project I have tried to implement SOLID principles for Clean Code purpose. I hope you will find it ok. As I have tested it though test methods in my project and seen everything is ok. Hope that you will accept the PR

@aatwi
Copy link
Owner

aatwi commented Feb 11, 2024

Hello,
Thanks for your contribution!
The purpose of the kata is for developers to refactor the code. Just as you did :)
If I merge your PR, then the other developers won't be able to refactor the code.

However, I might use your code as a solution branch.

@codenim34
Copy link
Author

Hello, Thanks for your contribution! The purpose of the kata is for developers to refactor the code. Just as you did :) If I merge your PR, then the other developers won't be able to refactor the code.

However, I might use your code as a solution branch.

Thank you . Can we be connected in linkedin ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants