Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MG-2048 - Authorize groups and channels with PATs #2501

Open
wants to merge 81 commits into
base: main
Choose a base branch
from

Conversation

nyagamunene
Copy link
Contributor

What type of PR is this?

This is a feature because it adds the following functionality: It adds authorization to groups and channels using PATs.

What does this do?

It adds PATs authorization to groups and channels middleware,

Which issue(s) does this PR fix/relate to?

Have you included tests for your changes?

Yes

Did you document any new/modified feature?

No

Notes

@nyagamunene nyagamunene self-assigned this Nov 3, 2024
@nyagamunene nyagamunene force-pushed the AuthorizeGroupsChannels branch 3 times, most recently from 618df09 to 2cab2ac Compare November 5, 2024 12:57
@arvindh123 arvindh123 changed the base branch from main to auth-refactor November 11, 2024 09:52
@arvindh123 arvindh123 force-pushed the auth-refactor branch 2 times, most recently from 3f43476 to 4323d34 Compare November 12, 2024 18:21
@dborovcanin dborovcanin force-pushed the auth-refactor branch 2 times, most recently from c04c035 to 37e5c2c Compare November 18, 2024 16:10
@dborovcanin dborovcanin force-pushed the auth-refactor branch 5 times, most recently from 9d4dce1 to 4daa02b Compare December 2, 2024 10:27
@nyagamunene nyagamunene changed the base branch from auth-refactor to main December 2, 2024 14:17
@nyagamunene nyagamunene force-pushed the AuthorizeGroupsChannels branch from 2cab2ac to 10bc421 Compare December 6, 2024 10:49
Copy link

codecov bot commented Dec 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 369 lines in your changes missing coverage. Please review.

Project coverage is 39.70%. Comparing base (378da93) to head (3a88df9).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
channels/middleware/authorization.go 0.00% 196 Missing ⚠️
groups/middleware/authorization.go 0.00% 171 Missing ⚠️
auth/service.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2501      +/-   ##
==========================================
- Coverage   45.41%   39.70%   -5.72%     
==========================================
  Files         404      279     -125     
  Lines       50517    41761    -8756     
==========================================
- Hits        22941    16580    -6361     
+ Misses      25207    23817    -1390     
+ Partials     2369     1364    -1005     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nyagamunene nyagamunene marked this pull request as ready for review December 6, 2024 11:17
@nyagamunene nyagamunene force-pushed the AuthorizeGroupsChannels branch 7 times, most recently from 1dcf4ee to 18fdf3e Compare December 11, 2024 18:03
@nyagamunene nyagamunene force-pushed the AuthorizeGroupsChannels branch from 18fdf3e to 8c34902 Compare January 2, 2025 19:55
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
nyagamunene and others added 27 commits January 7, 2025 10:12
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: Felix Gateru <[email protected]>
Signed-off-by: Arvindh <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
@nyagamunene nyagamunene force-pushed the AuthorizeGroupsChannels branch from 8168d78 to ff54754 Compare January 7, 2025 07:12
Signed-off-by: nyagamunene <[email protected]>
Copy link
Contributor

@arvindh123 arvindh123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🩺 Review and testing
Development

Successfully merging this pull request may close these issues.

3 participants