Worldpay: Add AFT support to Authorize and Purchase transaction types #5402
+48
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rachelkirk
commented
Feb 7, 2025
| aft_request(money, payment_method, payment_details.merge(**options)) | ||
| else | ||
| authorize_request(money, payment_method, payment_details.merge(options)) | ||
| end | ||
| end |
There was a problem hiding this comment.
As discussed in the ticket, this change was additive only. I left the AFT logic in the credit method until we determine it should be removed/updated according to Worldpay's docs
jcreiff
reviewed
Feb 7, 2025
Adds AFT fields to auth and purchase. CER-2069 Unit Tests 140 tests, 771 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote Tests 122 tests, 490 assertions, 11 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 90.9836% passed *11 tests also failing on master
rachelkirk
force-pushed
the
CER-2069_worldpay_aft_authpurchase
branch
from
990b70e to
632a9fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds AFT fields to auth and purchase.
CER-2069
Unit Tests
140 tests, 771 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
Remote Tests
122 tests, 490 assertions, 11 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 90.9836% passed
*11 tests also failing on master