[Mobile] Add support for searching child transactions

[joel-jeremy]

Resolved #4437

[netlify]

✅ Deploy Preview for actualbudget ready!

Name	Link
🔨 Latest commit	17678d4
🔍 Latest deploy log	https://app.netlify.com/sites/actualbudget/deploys/67c0a352ceef60000806c2ed
😎 Deploy Preview	https://deploy-preview-4471.demo.actualbudget.org
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[github-actions]

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
18	7.07 MB → 7.07 MB (+265 B)	+0.00%

Changeset

File	Δ	Size
node_modules/es-define-property/index.js	📈 +210 B (+60.00%)	350 B → 560 B
node_modules/has-property-descriptors/index.js	📈 +9 B (+1.57%)	573 B → 582 B
node_modules/call-bind/index.js	📈 +9 B (+0.85%)	1.04 kB → 1.05 kB
node_modules/define-data-property/index.js	📈 +9 B (+0.39%)	2.24 kB → 2.25 kB
src/components/mobile/accounts/AccountTransactions.tsx	📈 +28 B (+0.35%)	7.87 kB → 7.9 kB

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset	File Size	% Changed
static/js/index.js	4.35 MB → 4.35 MB (+237 B)	+0.01%
static/js/narrow.js	86.23 kB → 86.26 kB (+28 B)	+0.03%

Smaller

No assets were smaller

Unchanged

Asset	File Size	% Changed
static/js/es.js	60.58 kB	0%
static/js/en.js	103.18 kB	0%
static/js/nl.js	97.78 kB	0%
static/js/en-GB.js	98.67 kB	0%
static/js/de.js	114.35 kB	0%
static/js/fr.js	88.87 kB	0%
static/js/pt-BR.js	112.83 kB	0%
static/js/uk.js	111.11 kB	0%
static/js/indexeddb-main-thread-worker-e59fee74.js	13.5 kB	0%
static/js/resize-observer.js	18.37 kB	0%
static/js/workbox-window.prod.es5.js	5.69 kB	0%
static/js/useAccountPreviewTransactions.js	1.69 kB	0%
static/js/BackgroundImage.js	122.29 kB	0%
static/js/AppliedFilters.js	10.8 kB	0%
static/js/wide.js	102.9 kB	0%
static/js/ReportRouter.js	1.59 MB	0%

[github-actions]

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
1	1.34 MB	0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset	File Size	% Changed
kcab.worker.js	1.34 MB	0%

[coderabbitai]

Walkthrough

The changes modify the TransactionListWithPreviews function in the mobile account transactions component. The query parameter used to fetch transactions has been updated from { splits: 'none' } to { splits: 'all' }. Additionally, the function now includes a conditional check that filters out transactions marked as child (t.is_child) from the display list when no search is being performed.

Possibly related PRs

• Fixes #2703 - Fixes inaccurate running balance when hiding reconciled transactions #3603: Involved modifications to filtering logic in a component related to transaction display, addressing conditions similar to those in the TransactionListWithPreviews function.
• Add loading indicator when loading more transactions in mobile transaction list #3900: Addressed changes to transaction querying and display logic in a component that interacts with transaction data, which parallels the updates made in the current PR.

Suggested labels

:sparkles: Merged, :white_check_mark: Approved

Suggested reviewers

• youngcw

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7f50c73 and 17678d4.

⛔ Files ignored due to path filters (1)

• upcoming-release-notes/4471.md is excluded by !**/*.md

📒 Files selected for processing (1)

• packages/desktop-client/src/components/mobile/accounts/AccountTransactions.tsx (2 hunks)

🧰 Additional context used

🧠 Learnings (1)

packages/desktop-client/src/components/mobile/accounts/AccountTransactions.tsx (1)

Learnt from: jfdoming
PR: actualbudget/actual#3402
File: packages/desktop-client/src/components/accounts/Account.tsx:8-8
Timestamp: 2024-11-10T16:45:25.627Z
Learning: In the `AllTransactions` component of `Account.tsx`, the `useLayoutEffect` hook is appropriately used to dispatch an action that closes splits for parent transactions when `prependTransactions` changes, ensuring this occurs synchronously before the component is painted.

⏰ Context from checks skipped due to timeout of 90000ms (6)

• GitHub Check: test
• GitHub Check: build (macos-latest)
• GitHub Check: build (windows-latest)
• GitHub Check: build (ubuntu-latest)
• GitHub Check: Wait for Netlify build to finish
• GitHub Check: Analyze

🔇 Additional comments (2)

packages/desktop-client/src/components/mobile/accounts/AccountTransactions.tsx (2)

237-237: Changed query to include all transaction splits

The modification to use { splits: 'all' } instead of { splits: 'none' } is necessary to ensure all child transactions are retrieved from the backend. This enables the search functionality to include child transactions.

While this change is required for the search feature, be aware that it may slightly impact initial load performance as more data is being retrieved with every query, even when not searching.

---

332-335: Effective implementation of child transaction filtering

The conditional logic correctly implements the feature by:

1. Hiding child transactions during normal browsing for a cleaner interface
2. Including child transactions when searching for better discoverability

Note that when searching, only the matched transactions are shown (preview transactions are excluded), which is appropriate for search results.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[joel-jeremy]

Working on this got me thinking, I wonder if it's better to display all the child transactions in the mobile transaction list?

[matt-fidd]

Working on this got me thinking, I wonder if it's better to display all the child transactions in the mobile transaction list?

Personally I don't mind opening the transaction up if I need to see them, but I'd be happy either way. We always feel a bit limited for screen space on mobile is all.

[youngcw]

I worry that if we show splits by default on mobile it will be too full of a ledger. I think having a detail view modal could be nice. Press a transaction to get the details and have the option to edit. Maybe a long press could jump straight to edit