Skip to content

Commit

Permalink
fix setup, update htmldate and add tests (#460)
Browse files Browse the repository at this point in the history
* fix setup on MacOS and add tests

* use relevant htmldate branch

* use latest htmldate from repo

* new htmldate version + pin lxml
  • Loading branch information
adbar authored Jan 2, 2024
1 parent d31c8d7 commit 396b991
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 4 deletions.
7 changes: 6 additions & 1 deletion .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ jobs:
fail-fast: false
matrix:
os: [ubuntu-latest]
# https://github.com/actions/python-versions/blob/main/versions-manifest.json
python-version: ["3.9", "3.11"]
env: [{ MINIMAL: "true" }, { MINIMAL: "false" }]
include:
Expand All @@ -27,12 +28,16 @@ jobs:
python-version: 3.7
- os: macos-latest
python-version: 3.8
- os: macos-latest
python-version: "3.10"
- os: macos-latest
python-version: "3.12"
- os: windows-latest
python-version: 3.8
- os: ubuntu-latest
python-version: "3.10"
- os: ubuntu-latest
python-version: "3.12-dev"
python-version: "3.12"
steps:
# Python and pip setup
- name: Set up Python ${{ matrix.python-version }}
Expand Down
7 changes: 4 additions & 3 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -112,11 +112,12 @@ def get_long_description():
"charset_normalizer >= 3.0.1; python_version < '3.7'",
"charset_normalizer >= 3.2.0; python_version >= '3.7'",
"courlan >= 0.9.5",
"htmldate >= 1.6.0",
"htmldate >= 1.6.1",
"importlib_metadata; python_version < '3.8'",
"justext >= 3.0.0",
"lxml >= 4.9.3 ; platform_system != 'Darwin'",
"lxml == 4.9.2 ; platform_system == 'Darwin'",
# see tests on Github Actions
"lxml == 4.9.2 ; platform_system == 'Darwin' and python_version <= '3.8'",
"lxml == 4.9.4 ; platform_system != 'Darwin' or python_version > '3.8'",
"urllib3 >= 1.26, < 2; python_version < '3.7'",
"urllib3 >= 1.26, < 3; python_version >= '3.7'",
],
Expand Down

0 comments on commit 396b991

Please sign in to comment.