Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI downloads: use all information in settings file #734

Merged
merged 2 commits into from
Nov 1, 2024
Merged

Conversation

adbar
Copy link
Owner

@adbar adbar commented Oct 31, 2024

closes #732 and #733.

@adbar adbar marked this pull request as draft October 31, 2024 10:12
Copy link

codecov bot commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.98%. Comparing base (8f8d376) to head (8467dfd).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #734   +/-   ##
=======================================
  Coverage   98.97%   98.98%           
=======================================
  Files          21       21           
  Lines        3514     3530   +16     
=======================================
+ Hits         3478     3494   +16     
  Misses         36       36           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adbar adbar marked this pull request as ready for review November 1, 2024 12:58
@adbar adbar merged commit d695b68 into master Nov 1, 2024
13 checks passed
@adbar adbar deleted the fix_cli_config branch November 1, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CLI downloads: make sure all user-specified options are used
1 participant