Skip to content

SQL Injection when creating an application with Reactive SQL backend

High severity GitHub Reviewed Published Apr 7, 2022 in jhipster/generator-jhipster • Updated Jan 27, 2023

Package

npm generator-jhipster (npm)

Affected versions

>= 7.0.0, < 7.8.1

Patched versions

7.8.1

Description

Impact

SQL Injection vulnerability in entities for applications generated with the option "reactive with Spring WebFlux" enabled and an SQL database using r2dbc. Applications created without "reactive with Spring WebFlux" and applications with NoSQL databases are not affected.

If you have generated a microservice Gateway using the affected version, you might be impacted as Gateways are reactive by default.

Currently, SQL injection is possible in the findAllBy(Pageable pageable, Criteria criteria) method of an entity repository class generated in these applications as the where clause using Criteria for queries are not sanitized and user input is passed on as it is by the criteria.

Impacted applications

  • Monolith and microservice applications with SQL database and reactive with Spring WebFlux combination (other combinations are not affected and the issue is only present when you generate entities)
  • Gateway applications with SQL database (issue will appear only when generating entities)

Patches

Patched in v7.8.1

The findAllBy(Pageable pageable, Criteria criteria) method has been removed from the entity repositories and org.springframework.data.relational.core.query.Criteria support in the underlying methods has been replaced with org.springframework.data.relational.core.sql.Condition. This means you won't be able to do custom filtering in the generated applications.

If you have existing reactive applications generated by the impacted version, we advise you to audit for use of Criteria and take appropriate actions.

Workarounds

The problem lies in the EntityManager.java class when creating the where clause via Conditions.just(criteria.toString()).

just accepts the literal string provided. Criteria's toString method returns a plain string and this combination is vulnerable to sql injection as the string is not sanitized and will contain whatever used passed as input using any plain SQL

So be careful when combining criterias and conditions. As a workaround we have removed the possibility to pass any user-provided criteria to the createSelect method of EntityManager.

Example

Criteria criteria = Criteria.where("name").is("foobar';DROP TABLE example;--"); // parameter is user provided input
criteria.toString(); // --> "'foobar';DROP TABLE example;--'"

References

More details in this Issue report

For more information

If you have any questions or comments about this advisory:

References

@deepu105 deepu105 published to jhipster/generator-jhipster Apr 7, 2022
Published to the GitHub Advisory Database Apr 7, 2022
Reviewed Apr 7, 2022
Published by the National Vulnerability Database Apr 11, 2022
Last updated Jan 27, 2023

Severity

High

CVSS overall score

This score calculates overall vulnerability severity from 0 to 10 and is based on the Common Vulnerability Scoring System (CVSS).
/ 10

CVSS v3 base metrics

Attack vector
Network
Attack complexity
High
Privileges required
None
User interaction
None
Scope
Unchanged
Confidentiality
High
Integrity
High
Availability
High

CVSS v3 base metrics

Attack vector: More severe the more the remote (logically and physically) an attacker can be in order to exploit the vulnerability.
Attack complexity: More severe for the least complex attacks.
Privileges required: More severe if no privileges are required.
User interaction: More severe when no user interaction is required.
Scope: More severe when a scope change occurs, e.g. one vulnerable component impacts resources in components beyond its security scope.
Confidentiality: More severe when loss of data confidentiality is highest, measuring the level of data access available to an unauthorized user.
Integrity: More severe when loss of data integrity is the highest, measuring the consequence of data modification possible by an unauthorized user.
Availability: More severe when the loss of impacted component availability is highest.
CVSS:3.1/AV:N/AC:H/PR:N/UI:N/S:U/C:H/I:H/A:H

EPSS score

0.163%
(54th percentile)

Weaknesses

CVE ID

CVE-2022-24815

GHSA ID

GHSA-qjmq-8hjr-qcv6

Credits

Loading Checking history
See something to contribute? Suggest improvements for this vulnerability.