Chat completion: messages, stop, temperature, top_p, model, max_completion_tokens #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
December 13, 2024 07:44
- Update license in the pyproject - Add TODOs about whitelisting params - Mypy server.app - TODO to set flash attention to true
akxcv
reviewed
Dec 13, 2024
akxcv
reviewed
Dec 13, 2024
|
Sounds good! Could you create an issue for covering these parameters with tests, so we won't forget? |
akxcv
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement several "low hanging fruit" to align
/v1/chat/completionsarguments with OpenAI API.Most were already available, just needed verification, minor tweaking and testing.
Breaking change -
modelis now mandatory.Closes #1, #2, #3.