Chat completion chunk object #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 23, 2025 22:02
OpenAI doesn't include sampled token into top_logprobs if it's not there. We should do the same.
Add tests to remaining chat completion response chunk attributes. Refactor most of the tests: - remove non-local references - remove unused parametrization - separate deafult and streamed output tests (as the implementations are separate) - collect related test together - optimize prompts - remove duplicate tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added "developer" role in messages (closes #75).
Implemented/tested chat chunk completion object attributes (closes #77 (choices), #80 (index), #81 (logprobs), #85 (usage).
Fixed bug where
top_logprobswould occasionally include one more token than expected (llama-cpp-python used to include the sampled token amongtop_logprobs).Radically refactored tests: