Extract script tags to renderer.js file

ainvoner · Apr 25, 2017 · ca5a8b6 · ca5a8b6
1 parent 7881376
commit ca5a8b6
Show file tree

Hide file tree

Showing 3 changed files with 47 additions and 43 deletions.
diff --git a/default_app/index.html b/default_app/index.html
@@ -113,24 +113,6 @@
   </style>
 </head>
 <body>
-  <script>
-    const {remote, shell} = require('electron');
-
-    const execPath = remote.process.execPath;
-    const command = execPath + ' path-to-your-app';
-
-    document.onclick = function(e) {
-      e.preventDefault();
-      if (e.target.tagName == 'A')
-        shell.openExternal(e.target.href);
-      return false;
-    };
-    document.ondragover = document.ondrop = function(e) {
-      e.preventDefault();
-      return false;
-    };
-  </script>
-
   <div class="header">
     <svg class="header-icon" viewBox="0 0 32 32" xmlns="http://www.w3.org/2000/svg" aria-hidden="true">
       <g stroke="none" fill="none" fill-rule="evenodd">
@@ -185,31 +167,7 @@
   </div>
 
   <script>
-    const holder = document.getElementById('holder');
-    holder.ondragover = function () {
-      this.className = 'hover';
-      return false;
-    };
-    holder.ondragleave = holder.ondragend = function () {
-      this.className = '';
-      return false;
-    };
-    holder.ondrop = function (e) {
-      this.className = '';
-      e.preventDefault();
-
-      const file = e.dataTransfer.files[0];
-      require('child_process').execFile(execPath, [file.path], {
-        detached: true, stdio: 'ignore'
-      }).unref();
-      return false;
-    };
-
-    const version = process.versions.electron;
-    document.querySelector('.header-version').innerText = version;
-    document.querySelector('.command-example').innerText = command;
-    document.querySelector('.quick-start-link').href = `https://github.com/electron/electron/blob/v${version}/docs/tutorial/quick-start.md`;
-    document.querySelector('.docs-link').href = `https://github.com/electron/electron/tree/v${version}/docs#readme`;
+    require('./renderer')
   </script>
 </body>
 </html>
diff --git a/default_app/renderer.js b/default_app/renderer.js
@@ -0,0 +1,45 @@
+const {remote, shell} = require('electron')
+const {execFile} = require('child_process')
+
+const {execPath} = remote.process
+
+document.onclick = function (e) {
+  e.preventDefault()
+  if (e.target.tagName === 'A') {
+    shell.openExternal(e.target.href)
+  }
+  return false
+}
+
+document.ondragover = document.ondrop = function (e) {
+  e.preventDefault()
+  return false
+}
+
+const holder = document.getElementById('holder')
+holder.ondragover = function () {
+  this.className = 'hover'
+  return false
+}
+
+holder.ondragleave = holder.ondragend = function () {
+  this.className = ''
+  return false
+}
+
+holder.ondrop = function (e) {
+  this.className = ''
+  e.preventDefault()
+
+  const file = e.dataTransfer.files[0]
+  execFile(execPath, [file.path], {
+    detached: true, stdio: 'ignore'
+  }).unref()
+  return false
+}
+
+const version = process.versions.electron
+document.querySelector('.header-version').innerText = version
+document.querySelector('.command-example').innerText = `${execPath} path-to-your-app`
+document.querySelector('.quick-start-link').href = `https://github.com/electron/electron/blob/v${version}/docs/tutorial/quick-start.md`
+document.querySelector('.docs-link').href = `https://github.com/electron/electron/tree/v${version}/docs#readme`
diff --git a/filenames.gypi b/filenames.gypi
@@ -89,6 +89,7 @@
       'default_app/index.html',
       'default_app/main.js',
       'default_app/package.json',
+      'default_app/renderer.js',
     ],
     'lib_sources': [
       'atom/app/atom_content_client.cc',