Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full BIP 85 implementation, new repo name, PyPI foundations #1

Merged
merged 111 commits into from
May 26, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
111 commits
Select commit Hold shift + click to select a range
090e190
bip32 master keys working
akarve May 13, 2024
c8a9048
wip
akarve May 17, 2024
6a37665
all ckd functions stubbed
akarve May 18, 2024
856ebe2
wip; add ripemd fingerprint
akarve May 18, 2024
bb5ef0b
passing tests
akarve May 18, 2024
276a09a
call fingerpint in ckdpriv
akarve May 18, 2024
6fff4da
small refactor
akarve May 18, 2024
f853898
wip after major refactor and change to CKDpriv/pub
akarve May 20, 2024
6c5bbae
solving first use case
akarve May 20, 2024
ebabf05
major refactor and first test passing; adding completion notes on imp…
akarve May 21, 2024
49a4bbf
major change and fix to get first child deriv test vector working
akarve May 22, 2024
59845f5
most of first test vector working; add logging
akarve May 22, 2024
a4f1ea7
tweak comments
akarve May 22, 2024
a07b590
simplified flow control at master
akarve May 22, 2024
286ca9f
refactor ext_key into separate file
akarve May 22, 2024
0bb3fd0
organizational refactoring; all but ckdpub test passing
akarve May 22, 2024
e89b5d4
major refactor and tests supposedly work
akarve May 22, 2024
87a9368
ckdpub() not working but interprets
akarve May 22, 2024
4eec5bd
test vector 1 passing with ckdpub
akarve May 22, 2024
9cc39b5
added retry logic for CKDpub; all vector 1 tests passing
akarve May 22, 2024
38f0c27
add file
akarve May 22, 2024
fe37577
strip dead comment
akarve May 22, 2024
0a0a07f
strip more dead comments
akarve May 22, 2024
bc5ec50
strip dead code, rename
akarve May 22, 2024
3f14837
use bytes for depth everywhere
akarve May 22, 2024
c6a8a6e
pass test vector 2
akarve May 22, 2024
51b02cd
pass test vec 3
akarve May 22, 2024
84ca16b
test vector 4 pass
akarve May 22, 2024
cfa76aa
move vectors to separate file
akarve May 22, 2024
99668cc
All BIP32 tests passing
akarve May 22, 2024
43e256f
add vectors file
akarve May 22, 2024
602c829
makefile tweaks, use H for hardening symbol in 32 test vectors
akarve May 22, 2024
0d63e22
clean up comments and file names
akarve May 22, 2024
4dc22d1
fix negative tests, refactor derive_key to take master
akarve May 23, 2024
663757f
bip85 vector 1 passing
akarve May 24, 2024
32ea9b4
vector 2 85 pass
akarve May 24, 2024
04701f6
vector 3 without drng support
akarve May 24, 2024
38a4731
DRNG test passing
akarve May 24, 2024
12c704a
add 85 dicts
akarve May 24, 2024
6a81610
run all derivation through 85 generalized derive()
akarve May 24, 2024
a853df2
bip85 front door and more test vectors
akarve May 24, 2024
a855a78
simplification of not passing net and visibility when not needed; all…
akarve May 24, 2024
74b3709
passing first bip39 vecs
akarve May 24, 2024
650a5e8
passing all 39 vecs; need to test xprv
akarve May 24, 2024
5c6fbe6
all supported 39 tests passing
akarve May 24, 2024
7a5f6b3
everything working but CLI
akarve May 24, 2024
ca86b1a
some bip39 tests in 85 passing
akarve May 25, 2024
40c6678
85 39 tests working
akarve May 25, 2024
8534c77
passing 85 wif
akarve May 25, 2024
79b192b
pass xprv
akarve May 25, 2024
5724637
almost passing all 85 tests
akarve May 25, 2024
e2623ff
all but rsa
akarve May 25, 2024
0424edd
license
akarve May 25, 2024
13066c8
pypi wip
akarve May 25, 2024
f582f8a
test-reqs, actionlint
akarve May 25, 2024
dd711d1
ignore, __init__, makefile install-dev
akarve May 25, 2024
b35dca7
be sure to install test-requirements.txt
akarve May 25, 2024
d454199
override openssl.cnf
akarve May 25, 2024
ab03994
try setting env in test
akarve May 25, 2024
c694987
newline to openssl.cnf
akarve May 25, 2024
82ecc40
fix makefile separator
akarve May 25, 2024
ad94746
bump python setup to v5
akarve May 25, 2024
7195349
try python -m pytest
akarve May 25, 2024
1b7bf67
fix .cnf syntax
akarve May 25, 2024
f47544a
bump env earlier
akarve May 25, 2024
628d664
add a line
akarve May 25, 2024
c562cc7
expand python test matrix
akarve May 25, 2024
8097e4c
quote python versions
akarve May 25, 2024
13d03a1
clean up setup.py
akarve May 25, 2024
418038f
new readme
akarve May 25, 2024
c52e5dd
revised README
akarve May 25, 2024
618b85b
enhance README
akarve May 25, 2024
c6e7218
CLI stub and entry point
akarve May 25, 2024
69b3f51
add unsupported rsa test coverage
akarve May 25, 2024
4f57c7c
working cli stub
akarve May 25, 2024
fb71773
timeout
akarve May 25, 2024
6699714
cli validation
akarve May 25, 2024
1816174
cli tests
akarve May 25, 2024
afde0d9
more cli tests
akarve May 25, 2024
f8ad0f4
black
akarve May 25, 2024
1224beb
more unit tests
akarve May 25, 2024
d5e0a5a
getting to output xprv
akarve May 25, 2024
c085b69
fixed bug causing -n to be ignored for seed
akarve May 25, 2024
b085d66
unit test seed word cli generation
akarve May 25, 2024
4cff79b
Finished bipsea seed and tests
akarve May 25, 2024
0d08904
more test coverage
akarve May 25, 2024
81bb271
eliminate unnecessary str conversion
akarve May 25, 2024
c0c545a
testnet coverage
akarve May 25, 2024
b4477bf
lower case english seed words; set membership testing for bip39 inputs
akarve May 25, 2024
34b76ad
fix ci
akarve May 25, 2024
e35e3a2
small refactor
akarve May 26, 2024
1543d3f
handle warnings and entropy trimming when hashing arbitrary strings
akarve May 26, 2024
78159d9
clean whitespace
akarve May 26, 2024
3883e12
cover for from string case
akarve May 26, 2024
4bcc3ff
more test coverage, README
akarve May 26, 2024
f1c740f
fact our common warnings
akarve May 26, 2024
e21ab65
starting entropy cmd, tests passing
akarve May 26, 2024
71208a2
consolidate some files
akarve May 26, 2024
d5265ad
consolidate more
akarve May 26, 2024
6b5ad89
first bipsea entropy working
akarve May 26, 2024
a38a85c
secho not warnings.warn
akarve May 26, 2024
21f4e58
lint
akarve May 26, 2024
d840e1c
help cleanup
akarve May 26, 2024
a359540
consolidate into util; bipsea entropy almost done
akarve May 26, 2024
e150f64
clean up imports
akarve May 26, 2024
9109f51
isort
akarve May 26, 2024
0ca5020
isort?
akarve May 26, 2024
6e51534
resolve
akarve May 26, 2024
f13ee1c
solidify entropy cmd
akarve May 26, 2024
1ea4cd6
almost there: unit tests for entropy cli, file to 85, push to pypi
akarve May 26, 2024
f05bd81
black
akarve May 26, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
name: Test Python package

on: [push, pull_request]

jobs:
build:
env:
OPENSSL_CONF: ${{ github.workspace }}/config/openssl.cnf
runs-on: ubuntu-latest
strategy:
matrix:
python-version: ["3.8", "3.9", "3.10"]
steps:
- name: checkout repo
uses: actions/checkout@v4
- name: set up python ${{ matrix.python-version }}
uses: actions/setup-python@v5
with:
python-version: ${{ matrix.python-version }}
- name: install
run: make install
- name: lint
run: make check
- name: pytest
run: make test
2 changes: 2 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1 +1,3 @@
__pycache__
.DS_Store
*.egg-info
2 changes: 2 additions & 0 deletions .isort.cfg
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
[settings]
profile = black
222 changes: 201 additions & 21 deletions LICENSE.md
Original file line number Diff line number Diff line change
@@ -1,21 +1,201 @@
MIT License

Copyright (c) 2023 Aneesh Karve

Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
in the Software without restriction, including without limitation the rights
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
copies of the Software, and to permit persons to whom the Software is
furnished to do so, subject to the following conditions:

The above copyright notice and this permission notice shall be included in all
copies or substantial portions of the Software.

THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
SOFTWARE.
Apache License
Version 2.0, January 2004
http://www.apache.org/licenses/

TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION

1. Definitions.

"License" shall mean the terms and conditions for use, reproduction,
and distribution as defined by Sections 1 through 9 of this document.

"Licensor" shall mean the copyright owner or entity authorized by
the copyright owner that is granting the License.

"Legal Entity" shall mean the union of the acting entity and all
other entities that control, are controlled by, or are under common
control with that entity. For the purposes of this definition,
"control" means (i) the power, direct or indirect, to cause the
direction or management of such entity, whether by contract or
otherwise, or (ii) ownership of fifty percent (50%) or more of the
outstanding shares, or (iii) beneficial ownership of such entity.

"You" (or "Your") shall mean an individual or Legal Entity
exercising permissions granted by this License.

"Source" form shall mean the preferred form for making modifications,
including but not limited to software source code, documentation
source, and configuration files.

"Object" form shall mean any form resulting from mechanical
transformation or translation of a Source form, including but
not limited to compiled object code, generated documentation,
and conversions to other media types.

"Work" shall mean the work of authorship, whether in Source or
Object form, made available under the License, as indicated by a
copyright notice that is included in or attached to the work
(an example is provided in the Appendix below).

"Derivative Works" shall mean any work, whether in Source or Object
form, that is based on (or derived from) the Work and for which the
editorial revisions, annotations, elaborations, or other modifications
represent, as a whole, an original work of authorship. For the purposes
of this License, Derivative Works shall not include works that remain
separable from, or merely link (or bind by name) to the interfaces of,
the Work and Derivative Works thereof.

"Contribution" shall mean any work of authorship, including
the original version of the Work and any modifications or additions
to that Work or Derivative Works thereof, that is intentionally
submitted to Licensor for inclusion in the Work by the copyright owner
or by an individual or Legal Entity authorized to submit on behalf of
the copyright owner. For the purposes of this definition, "submitted"
means any form of electronic, verbal, or written communication sent
to the Licensor or its representatives, including but not limited to
communication on electronic mailing lists, source code control systems,
and issue tracking systems that are managed by, or on behalf of, the
Licensor for the purpose of discussing and improving the Work, but
excluding communication that is conspicuously marked or otherwise
designated in writing by the copyright owner as "Not a Contribution."

"Contributor" shall mean Licensor and any individual or Legal Entity
on behalf of whom a Contribution has been received by Licensor and
subsequently incorporated within the Work.

2. Grant of Copyright License. Subject to the terms and conditions of
this License, each Contributor hereby grants to You a perpetual,
worldwide, non-exclusive, no-charge, royalty-free, irrevocable
copyright license to reproduce, prepare Derivative Works of,
publicly display, publicly perform, sublicense, and distribute the
Work and such Derivative Works in Source or Object form.

3. Grant of Patent License. Subject to the terms and conditions of
this License, each Contributor hereby grants to You a perpetual,
worldwide, non-exclusive, no-charge, royalty-free, irrevocable
(except as stated in this section) patent license to make, have made,
use, offer to sell, sell, import, and otherwise transfer the Work,
where such license applies only to those patent claims licensable
by such Contributor that are necessarily infringed by their
Contribution(s) alone or by combination of their Contribution(s)
with the Work to which such Contribution(s) was submitted. If You
institute patent litigation against any entity (including a
cross-claim or counterclaim in a lawsuit) alleging that the Work
or a Contribution incorporated within the Work constitutes direct
or contributory patent infringement, then any patent licenses
granted to You under this License for that Work shall terminate
as of the date such litigation is filed.

4. Redistribution. You may reproduce and distribute copies of the
Work or Derivative Works thereof in any medium, with or without
modifications, and in Source or Object form, provided that You
meet the following conditions:

(a) You must give any other recipients of the Work or
Derivative Works a copy of this License; and

(b) You must cause any modified files to carry prominent notices
stating that You changed the files; and

(c) You must retain, in the Source form of any Derivative Works
that You distribute, all copyright, patent, trademark, and
attribution notices from the Source form of the Work,
excluding those notices that do not pertain to any part of
the Derivative Works; and

(d) If the Work includes a "NOTICE" text file as part of its
distribution, then any Derivative Works that You distribute must
include a readable copy of the attribution notices contained
within such NOTICE file, excluding those notices that do not
pertain to any part of the Derivative Works, in at least one
of the following places: within a NOTICE text file distributed
as part of the Derivative Works; within the Source form or
documentation, if provided along with the Derivative Works; or,
within a display generated by the Derivative Works, if and
wherever such third-party notices normally appear. The contents
of the NOTICE file are for informational purposes only and
do not modify the License. You may add Your own attribution
notices within Derivative Works that You distribute, alongside
or as an addendum to the NOTICE text from the Work, provided
that such additional attribution notices cannot be construed
as modifying the License.

You may add Your own copyright statement to Your modifications and
may provide additional or different license terms and conditions
for use, reproduction, or distribution of Your modifications, or
for any such Derivative Works as a whole, provided Your use,
reproduction, and distribution of the Work otherwise complies with
the conditions stated in this License.

5. Submission of Contributions. Unless You explicitly state otherwise,
any Contribution intentionally submitted for inclusion in the Work
by You to the Licensor shall be under the terms and conditions of
this License, without any additional terms or conditions.
Notwithstanding the above, nothing herein shall supersede or modify
the terms of any separate license agreement you may have executed
with Licensor regarding such Contributions.

6. Trademarks. This License does not grant permission to use the trade
names, trademarks, service marks, or product names of the Licensor,
except as required for reasonable and customary use in describing the
origin of the Work and reproducing the content of the NOTICE file.

7. Disclaimer of Warranty. Unless required by applicable law or
agreed to in writing, Licensor provides the Work (and each
Contributor provides its Contributions) on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
implied, including, without limitation, any warranties or conditions
of TITLE, NON-INFRINGEMENT, MERCHANTABILITY, or FITNESS FOR A
PARTICULAR PURPOSE. You are solely responsible for determining the
appropriateness of using or redistributing the Work and assume any
risks associated with Your exercise of permissions under this License.

8. Limitation of Liability. In no event and under no legal theory,
whether in tort (including negligence), contract, or otherwise,
unless required by applicable law (such as deliberate and grossly
negligent acts) or agreed to in writing, shall any Contributor be
liable to You for damages, including any direct, indirect, special,
incidental, or consequential damages of any character arising as a
result of this License or out of the use or inability to use the
Work (including but not limited to damages for loss of goodwill,
work stoppage, computer failure or malfunction, or any and all
other commercial damages or losses), even if such Contributor
has been advised of the possibility of such damages.

9. Accepting Warranty or Additional Liability. While redistributing
the Work or Derivative Works thereof, You may choose to offer,
and charge a fee for, acceptance of support, warranty, indemnity,
or other liability obligations and/or rights consistent with this
License. However, in accepting such obligations, You may act only
on Your own behalf and on Your sole responsibility, not on behalf
of any other Contributor, and only if You agree to indemnify,
defend, and hold each Contributor harmless for any liability
incurred by, or claims asserted against, such Contributor by reason
of your accepting any such warranty or additional liability.

END OF TERMS AND CONDITIONS

APPENDIX: How to apply the Apache License to your work.

To apply the Apache License to your work, attach the following
boilerplate notice, with the fields enclosed by brackets "[]"
replaced with your own identifying information. (Don't include
the brackets!) The text should be enclosed in the appropriate
comment syntax for the file format. We also recommend that a
file or class name and description of purpose be included on the
same "printed page" as the copyright notice for easier
identification within third-party archives.

Copyright [yyyy] [name of copyright owner]

Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at

http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
26 changes: 23 additions & 3 deletions Makefile
Original file line number Diff line number Diff line change
@@ -1,5 +1,25 @@
.PHONY: check install install-go lint test test-network

check:
black . --check
isort . --check

# developer install only
install:
pip install -r requirements.txt -r test-requirements.txt
pip install -e .

install-go:
# you must have go installed https://go.dev/doc/install
go install github.com/rhysd/actionlint/cmd/actionlint@latest

lint:
isort .
black .
actionlint

test:
python -m pytest tests/test.py -m "not network" -sx
python -m pytest tests -m "not network" -x

test-on:
python -m pytest tests/test.py
test-network:
python -m pytest tests
Loading