Skip to content

Bump bumpalo from 3.11.0 to 3.12.0 (#2) #6

Bump bumpalo from 3.11.0 to 3.12.0 (#2)

Bump bumpalo from 3.11.0 to 3.12.0 (#2) #6

GitHub Actions / clippy succeeded May 9, 2024 in 0s

clippy

10 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 10
Note 0
Help 0

Versions

  • rustc 1.77.2 (25ef9e3d8 2024-04-09)
  • cargo 1.77.2 (e52e36006 2024-03-26)
  • clippy 0.1.77 (25ef9e3 2024-04-09)

Annotations

Check warning on line 42 in src/io/obj_file.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

call to `reserve` immediately after creation

warning: call to `reserve` immediately after creation
  --> src/io/obj_file.rs:41:17
   |
41 | /                 let mut result = vec![];
42 | |                 result.reserve(size);
   | |_____________________________________^ help: consider using `Vec::with_capacity(/* Space hint */)`: `let mut result = Vec::with_capacity(size);`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#reserve_after_initialization
   = note: `#[warn(clippy::reserve_after_initialization)]` on by default

Check warning on line 108 in src/complex_structures/bvh.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

parameter is only used in recursion

warning: parameter is only used in recursion
   --> src/complex_structures/bvh.rs:108:9
    |
108 |         max_primitives_in_node: usize,
    |         ^^^^^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_max_primitives_in_node`
    |
note: parameter used here
   --> src/complex_structures/bvh.rs:211:51
    |
211 |             let left = self.recursive_build(info, max_primitives_in_node, objects, start, mid);
    |                                                   ^^^^^^^^^^^^^^^^^^^^^^
212 |             let right = self.recursive_build(info, max_primitives_in_node, objects, mid, end);
    |                                                    ^^^^^^^^^^^^^^^^^^^^^^
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#only_used_in_recursion
    = note: `#[warn(clippy::only_used_in_recursion)]` on by default

Check warning on line 230 in src/complex_structures/bvh.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

casting to the same type is unnecessary (`usize` -> `usize`)

warning: casting to the same type is unnecessary (`usize` -> `usize`)
   --> src/complex_structures/bvh.rs:230:17
    |
230 |                 index as usize
    |                 ^^^^^^^^^^^^^^ help: try: `index`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
    = note: `#[warn(clippy::unnecessary_cast)]` on by default

Check warning on line 62 in src/ray_tracer/scene.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

associated function `from_obj_file` is never used

warning: associated function `from_obj_file` is never used
  --> src/ray_tracer/scene.rs:62:19
   |
53 | impl Scene {
   | ---------- associated function in this implementation
...
62 |     pub(crate) fn from_obj_file(path: PathBuf, t: Tracing) -> anyhow::Result<Scene> {
   |                   ^^^^^^^^^^^^^

Check warning on line 21 in src/ray_tracer/scene.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

associated function `from_obj_file` is never used

warning: associated function `from_obj_file` is never used
  --> src/ray_tracer/scene.rs:21:19
   |
16 | impl LinearTracer {
   | ----------------- associated function in this implementation
...
21 |     pub(crate) fn from_obj_file(path: PathBuf) -> anyhow::Result<(LinearTracer, Vec<Material>)> {
   |                   ^^^^^^^^^^^^^

Check warning on line 9 in src/ray_tracer/material.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

field `optical_density` is never read

warning: field `optical_density` is never read
 --> src/ray_tracer/material.rs:9:16
  |
3 | pub(crate) struct Material {
  |                   -------- field in this struct
...
9 |     pub(crate) optical_density: f64,
  |                ^^^^^^^^^^^^^^^

Check warning on line 71 in src/complex_structures/bvh.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

associated function `from_obj_file` is never used

warning: associated function `from_obj_file` is never used
  --> src/complex_structures/bvh.rs:71:19
   |
70 | impl BVHTree {
   | ------------ associated function in this implementation
71 |     pub(crate) fn from_obj_file(path: PathBuf) -> anyhow::Result<(BVHTree, Vec<Material>)> {
   |                   ^^^^^^^^^^^^^

Check warning on line 45 in src/basic_geometry/vector.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

method `inverse` is never used

warning: method `inverse` is never used
  --> src/basic_geometry/vector.rs:45:19
   |
16 | impl Vector {
   | ----------- method in this implementation
...
45 |     pub(crate) fn inverse(&self) -> Vector {
   |                   ^^^^^^^

Check warning on line 52 in src/basic_geometry.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

variant `Scale` is never constructed

warning: variant `Scale` is never constructed
  --> src/basic_geometry.rs:52:5
   |
49 | pub(crate) enum Transformation {
   |                 -------------- variant in this enum
...
52 |     Scale(Vector),
   |     ^^^^^
   |
   = note: `Transformation` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis
   = note: `#[warn(dead_code)]` on by default

Check warning on line 15 in src/main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused imports: `Axis`, `Transform`

warning: unused imports: `Axis`, `Transform`
  --> src/main.rs:15:22
   |
15 | use basic_geometry::{Axis, Transform};
   |                      ^^^^  ^^^^^^^^^
   |
   = note: `#[warn(unused_imports)]` on by default