Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update angular 18 #3262

Merged
merged 10 commits into from
Aug 6, 2024
94 changes: 0 additions & 94 deletions .eslintrc.json

This file was deleted.

2 changes: 1 addition & 1 deletion .github/workflows/deploy-docs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: 18.13.0
node-version: 18.19.0
cache: 'npm'
- run: npm ci
- run: npm run docs:gh-pages
12 changes: 6 additions & 6 deletions .github/workflows/pr-check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: 18.13.0
node-version: 18.19.0
cache: 'npm'
- run: npm ci
- run: npm run build:packages
Expand All @@ -27,7 +27,7 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: 18.13.0
node-version: 18.19.0
cache: 'npm'
- run: |
npm ci
Expand All @@ -40,7 +40,7 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: 18.13.0
node-version: 18.19.0
- run: npm ci
- run: npm run docs:build
build-playground:
Expand All @@ -50,7 +50,7 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: 18.13.0
node-version: 18.19.0
- run: npm ci
- uses: actions/download-artifact@v2
with:
Expand Down Expand Up @@ -104,7 +104,7 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: 18.13.0
node-version: 18.19.0
- run: npm ci
- uses: actions/download-artifact@v2
with:
Expand Down Expand Up @@ -136,7 +136,7 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: 18.13.0
node-version: 18.19.0
- uses: actions/download-artifact@v2
with:
name: built-packages
Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
18.13.0
18.19.0
100 changes: 100 additions & 0 deletions eslint.config.mjs
Original file line number Diff line number Diff line change
@@ -0,0 +1,100 @@
import rxjs from "eslint-plugin-rxjs";
import globals from "globals";
import path from "node:path";
import { fileURLToPath } from "node:url";
import js from "@eslint/js";
import { FlatCompat } from "@eslint/eslintrc";

const __filename = fileURLToPath(import.meta.url);
const __dirname = path.dirname(__filename);
const compat = new FlatCompat({
baseDirectory: __dirname,
recommendedConfig: js.configs.recommended,
allConfig: js.configs.all
});

export default [{
ignores: [
"src/framework/**/*",
"docs/**/*",
"packages-smoke/**/*",
"tools/dev-schematics/*/files",
],
}, ...compat.extends(
"plugin:@angular-eslint/recommended",
"plugin:@angular-eslint/template/process-inline-templates",
"eslint-config-prettier",
).map(config => ({
...config,
files: ["**/*.ts"],
})), {
files: ["**/*.ts"],

plugins: {
rxjs,
},

languageOptions: {
ecmaVersion: 5,
sourceType: "script",

parserOptions: {
project: ["tsconfig.json", "e2e/tsconfig.json"],
createDefaultProgram: true,
},
},

rules: {
quotes: "off",
"dot-notation": "off",
"no-restricted-globals": ["error", "fit", "fdescribe"],
"@typescript-eslint/dot-notation": "error",
"no-shadow": "off",
"@typescript-eslint/no-shadow": "error",
"no-underscore-dangle": "off",
"@typescript-eslint/consistent-type-definitions": "error",

"rxjs/no-unsafe-takeuntil": ["error", {
allow: [
"count",
"defaultIfEmpty",
"endWith",
"every",
"finalize",
"finally",
"isEmpty",
"last",
"max",
"min",
"publish",
"publishBehavior",
"publishLast",
"publishReplay",
"reduce",
"share",
"shareReplay",
"skipLast",
"takeLast",
"throwIfEmpty",
"toArray",
],
}],
},
}, ...compat.extends("plugin:@angular-eslint/template/recommended", "eslint-config-prettier").map(config => ({
...config,
files: ["**/*.html"],
})), {
files: ["**/*.html"],
rules: {},
}, {
files: ["./*.js"],

languageOptions: {
globals: {
...globals.node,
},

ecmaVersion: 11,
sourceType: "commonjs",
},
}];
Loading
Loading