Skip to content

Commit

Permalink
Minor: Remove now dead SUPPORTED_STRUCT_TYPES
Browse files Browse the repository at this point in the history
  • Loading branch information
alamb committed Dec 9, 2023
1 parent 2536cda commit a7b0615
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 43 deletions.
7 changes: 2 additions & 5 deletions datafusion/expr/src/built_in_function.rs
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,7 @@ use crate::signature::TIMEZONE_WILDCARD;
use crate::type_coercion::binary::get_wider_type;
use crate::type_coercion::functions::data_types;
use crate::{
conditional_expressions, struct_expressions, FuncMonotonicity, Signature,
TypeSignature, Volatility,
conditional_expressions, FuncMonotonicity, Signature, TypeSignature, Volatility,
};

use arrow::datatypes::{DataType, Field, Fields, IntervalUnit, TimeUnit};
Expand Down Expand Up @@ -890,9 +889,7 @@ impl BuiltinScalarFunction {
// 0 or more arguments of arbitrary type
Signature::one_of(vec![VariadicAny, Any(0)], self.volatility())
}
BuiltinScalarFunction::Struct => Signature::variadic_any(
self.volatility(),
),
BuiltinScalarFunction::Struct => Signature::variadic_any(self.volatility()),
BuiltinScalarFunction::Concat
| BuiltinScalarFunction::ConcatWithSeparator => {
Signature::variadic(vec![Utf8], self.volatility())
Expand Down
1 change: 0 additions & 1 deletion datafusion/expr/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@ mod nullif;
mod operator;
mod partition_evaluator;
mod signature;
pub mod struct_expressions;
mod table_source;
pub mod tree_node;
pub mod type_coercion;
Expand Down
35 changes: 0 additions & 35 deletions datafusion/expr/src/struct_expressions.rs

This file was deleted.

4 changes: 2 additions & 2 deletions datafusion/physical-expr/src/struct_expressions.rs
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@
//! Struct expressions
use arrow::array::*;
use arrow::datatypes::{DataType, Field};
use datafusion_common::{exec_err, not_impl_err, DataFusionError, Result};
use arrow::datatypes::Field;
use datafusion_common::{exec_err, DataFusionError, Result};
use datafusion_expr::ColumnarValue;
use std::sync::Arc;

Expand Down

0 comments on commit a7b0615

Please sign in to comment.