Improve DW v3 performance #1262
Conversation
|
nop33
force-pushed
the
dw-redesign-ilias
branch
from
85ca69a to
35bf8cc
Compare
| @@ -50,7 +50,7 @@ const useFetchWalletFtsSymbols = () => { | |||
| const { | |||
| data: { listedFts }, | |||
| isLoading: isLoadingTokensByType | |||
| } = useFetchWalletTokensByType({ includeAlph: true }) | |||
| } = useFetchWalletTokensByType({ includeHidden: true }) | |||
There was a problem hiding this comment.
some defaults where changed, hence this diff
| id, | ||
| skip: isLoadingTokenType || tokenType?.stdInterfaceId !== e.TokenStdInterfaceId.NonFungible | ||
| }) | ||
| const { data, isLoading } = useQuery(tokenQuery({ id, networkId, isLoadingFtList, skip: !!listedFt })) |
There was a problem hiding this comment.
I spent a lot of time thinking "how can I cache the result of a hook so that it doesn't need to be recomputed every time it's called". Specifically, the problematic hook was useFetchToken. The body of the hook (seen on the left red diff), even though it uses the skip prop, it still requires a lot of computation.
The idea implemented here is to use Tanstack's native caching mechanism. My moving the code into a queryFn we benefit from caching. See below for implementation.
nop33
force-pushed
the
dw-redesign-ilias
branch
from
35bf8cc to
25f69cf
Compare
I will explain in detail the thought process behind these changes