Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce e2e tests #605

Merged
merged 5 commits into from
Jan 30, 2025
Merged

Introduce e2e tests #605

merged 5 commits into from
Jan 30, 2025

Conversation

tdroxler
Copy link
Member

No description provided.

@tdroxler tdroxler changed the title [Testing CI] Introduce e2e tests Introduce e2e tests Jan 27, 2025
@tdroxler tdroxler requested a review from h0ngcha0 January 27, 2025 10:55

const oneAlph = 10n ** 18n

const wallet = PrivateKeyWallet.FromMnemonic({
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For all the places where we use PrivateKeyWallet, maybe we can use getSigner instead.

const nodeProvider = new NodeProvider(configuration.nodeUrl)
const explorerProvider = new ExplorerProvider(configuration.explorerUrl)

const oneAlph = 10n ** 18n
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a constant called ONE_ALPH

@tdroxler tdroxler merged commit 09cf587 into master Jan 30, 2025
2 checks passed
@tdroxler tdroxler deleted the e2e branch January 30, 2025 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants