Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: [AAVE V3 Lending Protocol] Borrowing, Repayment, and Interest Accrual #58

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

codebestia
Copy link

Resolves #35

@raduciobanu22
Copy link
Collaborator

@codebestia I'm not sure what's your exact contribution to this PR. Should have branched-out from PR #46 and push your commits.

@codebestia
Copy link
Author

@codebestia I'm not sure what's your exact contribution to this PR. Should have branched-out from PR #46 and push your commits.

@raduciobanu22 These was my initial approach when i started but i looked at the contracts and saw that they were lacking in some ways and also, i looked at the PR and i saw no reviews, no comments and the contributor unassigned from issue which made me follow this approach. I followed the initial implementation of the PR #46 but i made some changes to the core structure.

  • I added multi token support because it was created with an implementation of dealing with one token which is not how a lending protocol works
  • I fixed some typos in the contract as well

I have added more functionality to the code base.
Please review it. I will finish it up soon and add tests.

@codebestia codebestia marked this pull request as ready for review January 5, 2025 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[AAVE V3 Lending Protocol] Issue 2: Borrowing, Repayment, and Interest Accrual
2 participants