fix(refinementList): canRefine is calculated for searchable #6494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this PR `canRefine` was always true for searchable. [FX-3190] BREAKING CHANGE: `canRefine` is false if there are no results from searchable if there's a query.
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit ba2dd77:
|
aymeric-giraudet
approved these changes
Dec 30, 2024
Haroenv
added a commit
that referenced
this pull request
Jan 9, 2025
Before this PR `canRefine` was always true for searchable. [FX-3190] BREAKING CHANGE: `canRefine` is false if there are no results from searchable if there's a query.
Haroenv
added a commit
that referenced
this pull request
Jan 17, 2025
Before this PR `canRefine` was always true for searchable. [FX-3190] BREAKING CHANGE: `canRefine` is false if there are no results from searchable if there's a query.
Haroenv
added a commit
that referenced
this pull request
Jan 17, 2025
Before this PR `canRefine` was always true for searchable. [FX-3190] BREAKING CHANGE: `canRefine` is false if there are no results from searchable if there's a query.
Haroenv
added a commit
that referenced
this pull request
Jan 17, 2025
Before this PR `canRefine` was always true for searchable. [FX-3190] BREAKING CHANGE: `canRefine` is false if there are no results from searchable if there's a query.
Haroenv
added a commit
that referenced
this pull request
Jan 17, 2025
Before this PR `canRefine` was always true for searchable. [FX-3190] BREAKING CHANGE: `canRefine` is false if there are no results from searchable if there's a query.
Haroenv
added a commit
that referenced
this pull request
Jan 21, 2025
Before this PR `canRefine` was always true for searchable. [FX-3190] BREAKING CHANGE: `canRefine` is false if there are no results from searchable if there's a query.
Haroenv
added a commit
that referenced
this pull request
Jan 21, 2025
Before this PR `canRefine` was always true for searchable. [FX-3190] BREAKING CHANGE: `canRefine` is false if there are no results from searchable if there's a query.
Haroenv
added a commit
that referenced
this pull request
Jan 22, 2025
Before this PR `canRefine` was always true for searchable. [FX-3190] BREAKING CHANGE: `canRefine` is false if there are no results from searchable if there's a query.
Haroenv
added a commit
that referenced
this pull request
Jan 22, 2025
Before this PR `canRefine` was always true for searchable. [FX-3190] BREAKING CHANGE: `canRefine` is false if there are no results from searchable if there's a query.
Haroenv
added a commit
that referenced
this pull request
Jan 27, 2025
Before this PR `canRefine` was always true for searchable. [FX-3190] BREAKING CHANGE: `canRefine` is false if there are no results from searchable if there's a query.
Haroenv
added a commit
that referenced
this pull request
Jan 28, 2025
Before this PR `canRefine` was always true for searchable. [FX-3190] BREAKING CHANGE: `canRefine` is false if there are no results from searchable if there's a query.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
canRefinewas always true for searchable.FX-3190
BREAKING CHANGE:
canRefineis false if there are no results from searchable if there's a query.