feat(routing): change default of cleanUrlOnDispose to false #6499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the vast majority of cases you're either never disposing InstantSearch, or the URL already gets cleared some other way (eg. through SPA navigation). This is why the new default for cleanUrlOnDispose is `false`. You'd still want to set this option to `true` if you're rendering instantsearch in a modal that should have the url cleared when that modal is closed. BREAKING CHANGE: default of cleanUrlOnDispose is false [FX-3213]
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 877e402:
|
dhayab
approved these changes
Dec 31, 2024
Co-authored-by: Dhaya <[email protected]>
Haroenv
added a commit
that referenced
this pull request
Jan 9, 2025
* feat(routing): change default of cleanUrlOnDispose to false In the vast majority of cases you're either never disposing InstantSearch, or the URL already gets cleared some other way (eg. through SPA navigation). This is why the new default for cleanUrlOnDispose is `false`. You'd still want to set this option to `true` if you're rendering instantsearch in a modal that should have the url cleared when that modal is closed. BREAKING CHANGE: default of cleanUrlOnDispose is false [FX-3213] * fix tests * Update packages/instantsearch-core/src/routing/historyRouter.ts Co-authored-by: Dhaya <[email protected]> --------- Co-authored-by: Dhaya <[email protected]>
Haroenv
added a commit
that referenced
this pull request
Jan 17, 2025
* feat(routing): change default of cleanUrlOnDispose to false In the vast majority of cases you're either never disposing InstantSearch, or the URL already gets cleared some other way (eg. through SPA navigation). This is why the new default for cleanUrlOnDispose is `false`. You'd still want to set this option to `true` if you're rendering instantsearch in a modal that should have the url cleared when that modal is closed. BREAKING CHANGE: default of cleanUrlOnDispose is false [FX-3213] * fix tests * Update packages/instantsearch-core/src/routing/historyRouter.ts Co-authored-by: Dhaya <[email protected]> --------- Co-authored-by: Dhaya <[email protected]>
Haroenv
added a commit
that referenced
this pull request
Jan 17, 2025
* feat(routing): change default of cleanUrlOnDispose to false In the vast majority of cases you're either never disposing InstantSearch, or the URL already gets cleared some other way (eg. through SPA navigation). This is why the new default for cleanUrlOnDispose is `false`. You'd still want to set this option to `true` if you're rendering instantsearch in a modal that should have the url cleared when that modal is closed. BREAKING CHANGE: default of cleanUrlOnDispose is false [FX-3213] * fix tests * Update packages/instantsearch-core/src/routing/historyRouter.ts Co-authored-by: Dhaya <[email protected]> --------- Co-authored-by: Dhaya <[email protected]>
Haroenv
added a commit
that referenced
this pull request
Jan 17, 2025
* feat(routing): change default of cleanUrlOnDispose to false In the vast majority of cases you're either never disposing InstantSearch, or the URL already gets cleared some other way (eg. through SPA navigation). This is why the new default for cleanUrlOnDispose is `false`. You'd still want to set this option to `true` if you're rendering instantsearch in a modal that should have the url cleared when that modal is closed. BREAKING CHANGE: default of cleanUrlOnDispose is false [FX-3213] * fix tests * Update packages/instantsearch-core/src/routing/historyRouter.ts Co-authored-by: Dhaya <[email protected]> --------- Co-authored-by: Dhaya <[email protected]>
Haroenv
added a commit
that referenced
this pull request
Jan 17, 2025
* feat(routing): change default of cleanUrlOnDispose to false In the vast majority of cases you're either never disposing InstantSearch, or the URL already gets cleared some other way (eg. through SPA navigation). This is why the new default for cleanUrlOnDispose is `false`. You'd still want to set this option to `true` if you're rendering instantsearch in a modal that should have the url cleared when that modal is closed. BREAKING CHANGE: default of cleanUrlOnDispose is false [FX-3213] * fix tests * Update packages/instantsearch-core/src/routing/historyRouter.ts Co-authored-by: Dhaya <[email protected]> --------- Co-authored-by: Dhaya <[email protected]>
Haroenv
added a commit
that referenced
this pull request
Jan 21, 2025
* feat(routing): change default of cleanUrlOnDispose to false In the vast majority of cases you're either never disposing InstantSearch, or the URL already gets cleared some other way (eg. through SPA navigation). This is why the new default for cleanUrlOnDispose is `false`. You'd still want to set this option to `true` if you're rendering instantsearch in a modal that should have the url cleared when that modal is closed. BREAKING CHANGE: default of cleanUrlOnDispose is false [FX-3213] * fix tests * Update packages/instantsearch-core/src/routing/historyRouter.ts Co-authored-by: Dhaya <[email protected]> --------- Co-authored-by: Dhaya <[email protected]>
Haroenv
added a commit
that referenced
this pull request
Jan 21, 2025
* feat(routing): change default of cleanUrlOnDispose to false In the vast majority of cases you're either never disposing InstantSearch, or the URL already gets cleared some other way (eg. through SPA navigation). This is why the new default for cleanUrlOnDispose is `false`. You'd still want to set this option to `true` if you're rendering instantsearch in a modal that should have the url cleared when that modal is closed. BREAKING CHANGE: default of cleanUrlOnDispose is false [FX-3213] * fix tests * Update packages/instantsearch-core/src/routing/historyRouter.ts Co-authored-by: Dhaya <[email protected]> --------- Co-authored-by: Dhaya <[email protected]>
Haroenv
added a commit
that referenced
this pull request
Jan 22, 2025
* feat(routing): change default of cleanUrlOnDispose to false In the vast majority of cases you're either never disposing InstantSearch, or the URL already gets cleared some other way (eg. through SPA navigation). This is why the new default for cleanUrlOnDispose is `false`. You'd still want to set this option to `true` if you're rendering instantsearch in a modal that should have the url cleared when that modal is closed. BREAKING CHANGE: default of cleanUrlOnDispose is false [FX-3213] * fix tests * Update packages/instantsearch-core/src/routing/historyRouter.ts Co-authored-by: Dhaya <[email protected]> --------- Co-authored-by: Dhaya <[email protected]>
Haroenv
added a commit
that referenced
this pull request
Jan 22, 2025
* feat(routing): change default of cleanUrlOnDispose to false In the vast majority of cases you're either never disposing InstantSearch, or the URL already gets cleared some other way (eg. through SPA navigation). This is why the new default for cleanUrlOnDispose is `false`. You'd still want to set this option to `true` if you're rendering instantsearch in a modal that should have the url cleared when that modal is closed. BREAKING CHANGE: default of cleanUrlOnDispose is false [FX-3213] * fix tests * Update packages/instantsearch-core/src/routing/historyRouter.ts Co-authored-by: Dhaya <[email protected]> --------- Co-authored-by: Dhaya <[email protected]>
Haroenv
added a commit
that referenced
this pull request
Jan 27, 2025
* feat(routing): change default of cleanUrlOnDispose to false In the vast majority of cases you're either never disposing InstantSearch, or the URL already gets cleared some other way (eg. through SPA navigation). This is why the new default for cleanUrlOnDispose is `false`. You'd still want to set this option to `true` if you're rendering instantsearch in a modal that should have the url cleared when that modal is closed. BREAKING CHANGE: default of cleanUrlOnDispose is false [FX-3213] * fix tests * Update packages/instantsearch-core/src/routing/historyRouter.ts Co-authored-by: Dhaya <[email protected]> --------- Co-authored-by: Dhaya <[email protected]>
Haroenv
added a commit
that referenced
this pull request
Jan 28, 2025
* feat(routing): change default of cleanUrlOnDispose to false In the vast majority of cases you're either never disposing InstantSearch, or the URL already gets cleared some other way (eg. through SPA navigation). This is why the new default for cleanUrlOnDispose is `false`. You'd still want to set this option to `true` if you're rendering instantsearch in a modal that should have the url cleared when that modal is closed. BREAKING CHANGE: default of cleanUrlOnDispose is false [FX-3213] * fix tests * Update packages/instantsearch-core/src/routing/historyRouter.ts Co-authored-by: Dhaya <[email protected]> --------- Co-authored-by: Dhaya <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the vast majority of cases you're either never disposing InstantSearch, or the URL already gets cleared some other way (eg. through SPA navigation). This is why the new default for cleanUrlOnDispose is
false.You'd still want to set this option to
trueif you're rendering instantsearch in a modal that should have the url cleared when that modal is closed.BREAKING CHANGE: default of cleanUrlOnDispose is false
FX-3213