fix(next-app-router): hydration error breaks routing #6542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aymeric-giraudet
requested review from
a team,
dhayab and
sarahdayan
and removed request for
a team
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit edd19a9:
|
Haroenv
approved these changes
Jan 22, 2025
|
@Haroenv it would be better with e2e tests as we could properly replicate the hydration issue. I can add tests maybe but this really is a quickfix intended to be removed once we ensure we always have a single instantsearch instance. |
|
all good @aymeric-giraudet ! |
dhayab
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #6541
Result
Kind of hacky, but hydration errors seem to trigger effect cleanup functions while not actually remounting the components ?
Note we wouldn't have this problem if we had an InstantSearch instance outside of React lifecycle, which should probably be the way to go for the stable release.