fix: rawContent was not correctly cloned (hence undefined) #6549
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixing an error made in #6544, where using
Object.create(content)
resulted inrawContent
always being an empty object and the final_rawContent
property always beingundefined
.Now using a custom method to smartly clone
content
without theresults
property, which behaves correctly.This approach avoids the need to delete the
results
property as it "just" creates a new object without it in the first place.This result in a more performant approach than using the existing
merge
util + deleting theresults
property afterward.Result
_rawContent
as retrieved in the below example is now not alwaysundefined
anymore.