Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3397 . #3415

Open
wants to merge 2 commits into
base: 1.8
Choose a base branch
from

code style: use code block with simple if.

3902153
Select commit
Loading
Failed to load commit list.
Open

Fix #3397 . #3415

code style: use code block with simple if.
3902153
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Aug 23, 2024 in 0s

45.88% (+0.02%) compared to 3892514

View this Pull Request on Codecov

45.88% (+0.02%) compared to 3892514

Details

Codecov Report

Attention: Patch coverage is 82.97872% with 8 lines in your changes missing coverage. Please review.

Project coverage is 45.88%. Comparing base (3892514) to head (3902153).
Report is 2 commits behind head on 1.8.

Files Patch % Lines
...a/csp/sentinel/annotation/aspectj/HandlerMeta.java 60.00% 2 Missing and 6 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                1.8    #3415      +/-   ##
============================================
+ Coverage     45.85%   45.88%   +0.02%     
- Complexity     2148     2151       +3     
============================================
  Files           431      432       +1     
  Lines         12932    12972      +40     
  Branches       1728     1733       +5     
============================================
+ Hits           5930     5952      +22     
- Misses         6301     6316      +15     
- Partials        701      704       +3     
Components Coverage Δ
sentinel-adapter 43.22% <ø> (ø)
sentinel-cluster 23.71% <ø> (ø)
sentinel-core 59.62% <ø> (-0.02%) ⬇️
sentinel-extension 46.08% <82.97%> (+0.20%) ⬆️
sentinel-logging 54.54% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.