Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug][tools] fix source release contains ._* files when build on Mac #339

Merged
merged 1 commit into from
Jan 30, 2025
Merged

[bug][tools] fix source release contains ._* files when build on Mac #339

merged 1 commit into from
Jan 30, 2025

Conversation

psxjoy
Copy link
Contributor

@psxjoy psxjoy commented Jan 28, 2025

Purpose

fix #335

Remove the source release ._* files when build on Mac

Tests

Run tools/releasing/create_source_release.sh

API and Format

Not applicable.

Documentation

Not applicable.

@psxjoy psxjoy marked this pull request as draft January 28, 2025 15:28
@psxjoy psxjoy marked this pull request as ready for review January 28, 2025 16:24
wuchong
wuchong approved these changes Jan 30, 2025
View reviewed changes
Copy link
Member

@wuchong wuchong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@wuchong wuchong merged commit 3a9772f into alibaba:main Jan 30, 2025
2 checks passed
@psxjoy psxjoy deleted the fix-build-on-mac branch January 30, 2025 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wuchong wuchong wuchong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] The source release contains ._* files when build on Mac
2 participants
@psxjoy @wuchong