Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refine the OIDC credentials provider #100

Merged
merged 1 commit into from
Aug 20, 2024
Merged

refine the OIDC credentials provider #100

merged 1 commit into from
Aug 20, 2024

Conversation

JacksonTian
Copy link
Contributor

You need to complete
  • unit tests and/or feature tests
  • documentation is changed or added

@JacksonTian JacksonTian force-pushed the oidc branch 2 times, most recently from 8a1cc01 to db0865d Compare August 20, 2024 07:44
@codecov-commenter
Copy link

codecov-commenter commented Aug 20, 2024

Codecov Report

Attention: Patch coverage is 98.06452% with 3 lines in your changes missing coverage. Please review.

Project coverage is 93.19%. Comparing base (e686912) to head (a3dd655).

Files Patch % Lines
credentials/internal/providers/oidc.go 97.90% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #100      +/-   ##
==========================================
+ Coverage   93.15%   93.19%   +0.03%     
==========================================
  Files          26       26              
  Lines        1651     1675      +24     
==========================================
+ Hits         1538     1561      +23     
- Misses        107      108       +1     
  Partials        6        6              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JacksonTian JacksonTian merged commit f5d62c4 into master Aug 20, 2024
8 checks passed
@JacksonTian JacksonTian deleted the oidc branch August 20, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants