Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor config setters #119

Merged
merged 1 commit into from
Sep 14, 2024
Merged

refactor config setters #119

merged 1 commit into from
Sep 14, 2024

Conversation

yndu13
Copy link
Collaborator

@yndu13 yndu13 commented Sep 14, 2024

You need to complete
  • unit tests and/or feature tests
  • documentation is changed or added

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.93%. Comparing base (1d5d242) to head (e3948a9).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #119   +/-   ##
=======================================
  Coverage   98.93%   98.93%           
=======================================
  Files          30       30           
  Lines        2064     2067    +3     
=======================================
+ Hits         2042     2045    +3     
  Misses         12       12           
  Partials       10       10           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JacksonTian JacksonTian merged commit 5a1e97f into master Sep 14, 2024
11 of 12 checks passed
@JacksonTian JacksonTian deleted the setter branch September 14, 2024 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants