Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support RoleSessionExpiration for OIDCCredential #55

Merged
merged 1 commit into from
Nov 17, 2023

Conversation

yndu13
Copy link
Collaborator

@yndu13 yndu13 commented Nov 17, 2023

You need to complete
  • unit tests and/or feature tests
  • documentation is changed or added

@codecov-commenter
Copy link

codecov-commenter commented Nov 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f9ce06a) 91.66% compared to head (d8860e4) 91.69%.

❗ Current head d8860e4 differs from pull request most recent head 6f06583. Consider uploading reports for the commit 6f06583 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #55      +/-   ##
==========================================
+ Coverage   91.66%   91.69%   +0.02%     
==========================================
  Files          20       20              
  Lines        1212     1216       +4     
==========================================
+ Hits         1111     1115       +4     
  Misses         82       82              
  Partials       19       19              
Flag Coverage Δ
credentials-go 91.69% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yndu13 yndu13 force-pushed the oidc-session-expiration branch 2 times, most recently from 1d918b8 to 6f06583 Compare November 17, 2023 07:58
@yndu13 yndu13 force-pushed the oidc-session-expiration branch from 6f06583 to 0f50690 Compare November 17, 2023 08:47
@JacksonTian JacksonTian merged commit 6e16e9a into master Nov 17, 2023
7 checks passed
@JacksonTian JacksonTian deleted the oidc-session-expiration branch November 17, 2023 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants